[ 
https://issues.apache.org/jira/browse/AVRO-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522825#comment-15522825
 ] 

ASF GitHub Bot commented on AVRO-1907:
--------------------------------------

GitHub user gszadovszky opened a pull request:

    https://github.com/apache/avro/pull/130

    AVRO-1907 - Add logging to logical type handling in java library

    Didn't find other parts related to logical type handling where we would 
swallow an exception and therefore, some logging is required. 
    Please, review and comment any idea if I should look into something more 
deeply.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gszadovszky/avro AVRO-1907

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/avro/pull/130.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #130
    
----
commit 8810a93e00880396c7251e38defe97e3d41ba6f8
Author: Gabor Szadovszky <[email protected]>
Date:   2016-09-26T11:44:25Z

    AVRO-1907 - Add logging to logical type handling in java library

----


> Add logging to logical type handling in java library
> ----------------------------------------------------
>
>                 Key: AVRO-1907
>                 URL: https://issues.apache.org/jira/browse/AVRO-1907
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.8.0
>            Reporter: Sean Busbey
>
> Right now we don't have any logging while handling logical type information 
> in a Schema. In particular, we use {{LogicalTypes.fromSchemaIgnoreInvalid}} 
> which means when folks have a problem in their schema logical types just 
> disappear with no debugging information.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to