[
https://issues.apache.org/jira/browse/AVRO-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546893#comment-15546893
]
ASF GitHub Bot commented on AVRO-1681:
--------------------------------------
GitHub user radai-rosenblatt opened a pull request:
https://github.com/apache/avro/pull/139
Make 1.7 branch build
Seems like AVRO-1681 was only partially applied to the 1.7 branch.
Specifically, the expected test output was not updated to reflect changes in
javadoc.
This commit fixes the tests and makes the build pass
Signed-off-by: radai-rosenblatt <[email protected]>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radai-rosenblatt/avro make-1.7-build
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/avro/pull/139.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #139
----
commit ae3e189927aaf42d36dbb6248915b97a9dad766b
Author: radai-rosenblatt <[email protected]>
Date: 2016-10-04T22:36:18Z
Make 1.7 branch actually build
Seems like AVRO-1681 was only partially applied to the 1.7 branch.
Specifically, the expected test output was not updated to reflect changes in
javadoc.
This commit fixes the tests and makes the build pass
Signed-off-by: radai-rosenblatt <[email protected]>
----
> Improve generated JavaDocs
> --------------------------
>
> Key: AVRO-1681
> URL: https://issues.apache.org/jira/browse/AVRO-1681
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.7.7
> Reporter: Charles Gariépy-Ikeson
> Assignee: Charles Gariépy-Ikeson
> Priority: Minor
> Fix For: 1.7.8, 1.8.0
>
> Attachments: AVRO-1681-TRUNK.patch, AVRO-1681.patch
>
>
> Hi everyone!
> I've noticed that the JavaDocs generated by the SpecificCompiler could use a
> little TLC. Our usage of Avro includes the IPC component, and it would be
> nice if the JavaDocs that were generated from our avpr files were a little
> more verbose, especially when working with IDEs that integrate JavaDocs from
> the classes we are using. It would help usage of the interfaces and classes
> generated from the protocol file, without having to dive deeper into the
> class or protocol file from which it was generated.
> I've made a first attempt at accomplishing this. This is my first patch, so
> don't hesitate to point out something I've missed or needs improving.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
