[
https://issues.apache.org/jira/browse/AVRO-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563681#comment-15563681
]
Suraj Acharya commented on AVRO-1887:
-------------------------------------
So i wrote the plugin for the yetus usage.
{code}
[root@sacharya-docker avro]# test-patch.sh --plugins=all
--user-plugins=/root/avro/pre_commit/ --list-plugins
Reminder: every plug-in may be enabled via 'all'.
BUILDTOOLS:
ant autoconf cmake gradle make maven nobuild build
TESTTYPES:
asflicense author cc checkstyle findbugs javac javadoc mvnsite mvneclipse
perlcritic pylint rubocop ruby_lint scalac scaladoc shellcheck shelldocs
test4tests unitveto whitespace xml buildtest
BUGSYSTEMS:
brieftext bugzilla github htmlout jira
TESTFORMATS:
ctest junit tap
{code}
The build tool is build and the build test tool is buildtest.
I tried with a couple different patches and found the results to be pretty
consistent.
{code}
| Vote | Subsystem | Runtime | Comment
============================================================================
| 0 | pylint | 0m 4s | Pylint was not available.
| +1 | @author | 0m 0s | The patch does not contain any @author
| | | | tags.
| +1 | buildtest | 0m 0s | master passed
| -1 | whitespace | 0m 0s | The patch has 3 line(s) that end in
| | | | whitespace. Use git apply
| | | | --whitespace=fix <<patch_file>>. Refer
| | | | https://git-scm.com/docs/git-apply
| +1 | buildtest | 0m 18s | the patch passed
| | | 0m 24s |
{code}
The usage is something like :
{code}
test-patch.sh --plugins=all --user-plugins=/root/avro/pre_commit/
--build-tool=build <PATCH FILE> --robot
{code}
Currently I havent givent any JIRA credentials but the same can be passed to
the builds.apache machine.
> set up precommit checks via Apache Yetus
> ----------------------------------------
>
> Key: AVRO-1887
> URL: https://issues.apache.org/jira/browse/AVRO-1887
> Project: Avro
> Issue Type: Task
> Components: build, community
> Reporter: Sean Busbey
> Assignee: Suraj Acharya
> Priority: Blocker
>
> The lack of automated checks for things like doing a full build is negatively
> impacting my ability to do timely reviews. We should leverage the work done
> by other communities and get precommit checks going with Apache Yetus ([ref
> Apache Yetus
> Precommit|http://yetus.apache.org/documentation/0.3.0/precommit-basic/])
> Yetus has built in support for using Docker as a containerized build
> environment ([ref
> docs|https://yetus.apache.org/documentation/0.3.0/precommit-advanced/#Docker_Support]),
> but I don't know if we can use the one we have directly or if we'll need to
> do some refactoring.
> Implementing this will ultimately require a committer (so that they can make
> changes to builds.apache.org), but a non-cmmitter can get the bulk of the
> work done by managing to do local yetus checks with the docker feature active.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
