[
https://issues.apache.org/jira/browse/AVRO-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880471#comment-15880471
]
Elliot West edited comment on AVRO-1933 at 2/23/17 3:37 PM:
------------------------------------------------------------
[~epkanol], I do not have permission to attach my patch to this ticket so have
instead created a new issue, AVRO-2003, that depends on this one. The patch is
probably clearer and my issue better documented this way too. I've updated all
the test cases and added more.
One further thought; perhaps the noun 'results' might better describe the
return type than 'details'. This would lead to a classname of
{{SchemaCompatibilityResults}} and also
{{SchemaPairCompatibility.getResults()}}. Additionally, the term 'details' in
{{SchemaCompatibilityDetails}} might be better described as the 'message'?
These changes would avoid the potential ungainly invocation chain of:
{{SchemaPairCompatibility.getDetails().getDetails()}} and would become:
{{SchemaPairCompatibility.getResults().getMessage()}}
was (Author: teabot):
[~epkanol], I do not have permission to attach my patch to this ticket so have
instead created a new issue, AVRO-2003, that depends on this one. The patch is
probably clearer and my issue better documented this way too. I've updated all
the test cases and added more.
One further thought; perhaps the noun 'results' might better describe the
return type than 'details'. This would lead to a classname of
{{SchemaCompatibilityResults}} and also
{{SchemaPairCompatibility.getResults()}}. Additionally, the term 'details' in
{{SchemaCompatibilityDetails}} might be better described as the 'message'?
These changes would avoid the potential ungainly invocation chain of:
{{SchemaPairCompatibility.getDetails().getDetails()}} which would become:
{{SchemaPairCompatibility.getResults().getMessage()}}
> SchemaCompatibility class could be more user-friendly about incompatibilities
> -----------------------------------------------------------------------------
>
> Key: AVRO-1933
> URL: https://issues.apache.org/jira/browse/AVRO-1933
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.8.1
> Environment: Any Java env
> Reporter: Anders Sundelin
> Priority: Minor
> Fix For: 1.9.0
>
> Attachments: AVRO-1933-compatible-with-AVRO-1931.patch,
> AVRO-1933.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Today, the class SchemaCompatibility reports incompatibilities with quite
> little detail. The whole reader and the whole writer schema is listed, and no
> particular detail about what was incompatible.
> The attached patch fixes this, introducing a new enum
> (SchemaIncompatibilityType), and more specific sub-schemas that were
> incompatible.
> The old, overall picture, is still there - the new compatibility state is
> encapsulated in the SchemaCompatibilityDetails class.
> Lots of test cases have been added, and there has been refactoring done in
> the TestSchemaCompatibility and other test classes.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
