Barring someone from the javascript side of the project piping up about branch-1.7, I'd be inclined to vote in favor of at least removing the javascript libraries from the default top-level build and convenience binaries for 1.7.
On Wed, Mar 22, 2017 at 5:31 PM, suraj acharya <[email protected]> wrote: > Hi, > I have been trying for the last couple of weeks and I still haven't made > progress. > > I am inclined to now call for a vote to decouple JS from 1.7.X. > > Thanks > > Suraj > > > -Suraj Acharya > > On Wed, Mar 1, 2017 at 9:43 AM, suraj acharya <[email protected]> wrote: > >> Hi Ryan, >> Thanks for the reply. >> I was on Node 6. >> However, I am getting the same error on Node 4 and Node 5. >> bash-4.1# ./build.sh test >> npm WARN [email protected] license should be a valid SPDX license expression >> A valid Gruntfile could not be found. Please see the getting started guide >> for >> more information on how to configure grunt: http://gruntjs.com/getting-sta >> rted >> Fatal error: Unable to find Gruntfile. >> bash-4.1# npm version >> { 'avro-js': '0.0.1', >> npm: '3.7.3', >> ares: '1.10.1-DEV', >> http_parser: '2.6.2', >> icu: '56.1', >> modules: '47', >> node: '5.9.0', >> openssl: '1.0.2g', >> uv: '1.8.0', >> v8: '4.6.85.31', >> zlib: '1.2.8' } >> bash-4.1# npm version >> { 'avro-js': '0.0.1', >> npm: '2.15.11', >> ares: '1.10.1-DEV', >> http_parser: '2.7.0', >> icu: '56.1', >> modules: '46', >> node: '4.7.3', >> openssl: '1.0.2k', >> uv: '1.9.1', >> v8: '4.5.103.43', >> zlib: '1.2.8' } >> bash-4.1# ./build.sh test >> npm WARN package.json [email protected] license should be a valid SPDX >> license expression >> [email protected] node_modules/underscore >> >> [email protected] node_modules/grunt >> ├── [email protected] >> ├── [email protected] >> ├── [email protected] >> ├── [email protected] >> ├── [email protected] >> ├── [email protected] >> ├── [email protected] >> ├── [email protected] ([email protected]) >> ├── [email protected] ([email protected], [email protected], [email protected], >> [email protected]) >> ├── [email protected] ([email protected]) >> ├── [email protected] ([email protected]) >> ├── [email protected] ([email protected]) >> ├── [email protected] ([email protected], [email protected]) >> ├── [email protected] ([email protected], [email protected]) >> ├── [email protected] ([email protected], [email protected], [email protected], >> [email protected], [email protected], [email protected]) >> └── [email protected] ([email protected], [email protected], >> [email protected], [email protected], [email protected]) >> A valid Gruntfile could not be found. Please see the getting started guide >> for >> more information on how to configure grunt: http://gruntjs.com/getting-sta >> rted >> Fatal error: Unable to find Gruntfile. >> >> I looked at the travis job you had shared. Comparing the commits on it, it >> looks like the master is based on 1.8. I am trying to make 1.7 build and >> test. >> Do you think it is worthwhile to make the build.sh of 1.7 similar to the >> one in 1.8? I see there are a lot of fundamental differences, and if we are >> to back port those over, I am not sure if there are going to be other >> issues. >> >> Can you give some pointers on the same? >> >> >> -Suraj Acharya >> >> On Tue, Feb 28, 2017 at 2:29 AM, Ryan Blue <[email protected]> >> wrote: >> >>> Suraj, >>> >>> I separated out a few implementations into separate repositories, set >>> up Travis CI, and fixed a few tests in different implementations. It >>> looks like the one for JS has tests passing in Node JS 4 and 5, but >>> broken in 6: https://travis-ci.org/rdblue/avro-js/builds/187343704 >>> >>> You may be running with Node JS 6? >>> >>> rb >>> >>> On Mon, Feb 27, 2017 at 4:29 AM, suraj acharya <[email protected]> >>> wrote: >>> > I was attempting to make a release for 1.7.X. >>> > In the process I am running into failing JS tests. >>> > I was wondering if someone who worked on JS for AVRO can take a look at >>> the >>> > issue. >>> > If there are no takers for the same, does anyone have objection if for >>> > Branch-1.7 the JS component is removed? The builds on Branch-1.8 and >>> higher >>> > are working fine. There have been changes to the way the npm setup >>> happens >>> > in Branch-1.8. >>> > >>> > Any help is appreciated. >>> > >>> > -Suraj Acharya >>> >>> >>> >>> -- >>> Ryan Blue >>> Software Engineer >>> Netflix >>> >> >> -- busbey
