GitHub user johnsgill3 opened a pull request:
https://github.com/apache/avro/pull/217
AVRO-1167, AVRO-766: Fix c AVRO_LINK memory leaks
Fixes AVRO-766
Fixes AVRO-1167
- Correct reference accounting during `avro_schema_copy`
- Save Named Schemas (Records, Enum, Fixed) during copy into hash
- Use new Avro named schema in link target from saved hash
- Adds tests cases from patches in AVRO-766 & ARRo-1167
Running the test cases through valgrind does not generate any memory leak
errors.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/johnsgill3/avro fix-c-link-memory-leaks
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/avro/pull/217.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #217
----
commit 712c47cc1b8f1f5f5395c6ad72857ea5b73c3711
Author: John Gill <[email protected]>
Date: 2017-04-15T17:01:38Z
AVRO-1167: Enhance avro_schema_copy for AVRO_LINK
- Add hash of named schemas found during copy
- Find saved named schema for copy of AVRO_LINK
commit f587ade67f0856ebdfa1106089e7963bf60bc495
Author: John Gill <[email protected]>
Date: 2017-04-15T20:02:02Z
AVRO-766: Correct memory leaks in AVRO_LINK copy
- Adds test cases for AVRO-766 & AVRO-1167
- Corrects reference counting for avro_schema_copy
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
