Anyone available to review this pull request? thank you
—Z > On Apr 10, 2017, at 12:12 PM, Zoltan Farkas <zolyfar...@yahoo.com.INVALID> > wrote: > > Hi, I have updated my pull request with latest suggestions from Ryan, > > can somebody review this pull request and let me know if there is anything > left? > > thank you > > —Z > >> Begin forwarded message: >> >> From: "Zoltan Farkas (JIRA)" <j...@apache.org> >> Subject: [jira] [Updated] (AVRO-1723) Add support for forward declarations >> in avro IDL >> Date: April 6, 2017 at 10:50:41 AM PDT >> To: dev@avro.apache.org >> Reply-To: dev@avro.apache.org >> >> >> [ >> https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel >> ] >> >> Zoltan Farkas updated AVRO-1723: >> -------------------------------- >> Release Note: >> Pull request available: >> >> https://github.com/apache/avro/pull/79 >> Status: Patch Available (was: Open) >> >> Pull request available: >> >> https://github.com/apache/avro/pull/79 >> >>> Add support for forward declarations in avro IDL >>> ------------------------------------------------ >>> >>> Key: AVRO-1723 >>> URL: https://issues.apache.org/jira/browse/AVRO-1723 >>> Project: Avro >>> Issue Type: Improvement >>> Affects Versions: 1.8.0 >>> Reporter: Zoltan Farkas >>> Assignee: Zoltan Farkas >>> Attachments: AVRO-1723.patch >>> >>> >>> Currently Recursive data structures like: >>> record SampleNode { >>> int count = 0; >>> array<SamplePair> samples = []; >>> } >>> record SamplePair { >>> string name; >>> SampleNode node; >>> } >>> It is not possible to declare in IDL, >>> however it is possible to declare in avsc (with fix from >>> https://issues.apache.org/jira/browse/AVRO-1667 ) >>> It is actually not complicated to implement, here is some detail on a >>> possible implementation: >>> https://github.com/zolyfarkas/avro/commit/210c50105717149f3daa39b8d4160b8548b8e363 >>> This would close a capability gap with google protocol buffers... >> >> >> >> -- >> This message was sent by Atlassian JIRA >> (v6.3.15#6346) >
