[ 
https://issues.apache.org/jira/browse/AVRO-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988082#comment-15988082
 ] 

Hadoop QA commented on AVRO-2003:
---------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m  
0s{color} | {color:red} java in the patch failed. {color} |
| {color:green}+1{color} | {color:green} buildtest {color} | {color:green}  6m 
39s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m  
2s{color} | {color:red} java in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m  
1s{color} | {color:red} java in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m  1s{color} 
| {color:red} java in the patch failed. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  
0s{color} | {color:red} The patch has 21 line(s) that end in whitespace. Use 
git apply --whitespace=fix <<patch_file>>. Refer 
https://git-scm.com/docs/git-apply {color} |
| {color:green}+1{color} | {color:green} buildtest {color} | {color:green}  6m 
21s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m  
2s{color} | {color:red} java in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m 37s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.13.1 Server=1.13.1 Image:yetus/avro:793178a |
| JIRA Issue | AVRO-2003 |
| GITHUB PR | https://github.com/apache/avro/pull/201 |
| Optional Tests |  buildtest  javac  compile  javadoc  |
| uname | Linux 5ed3aa5d1014 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 
15:44:32 UTC 2016 x86_64 GNU/Linux |
| Build tool | build |
| git revision | master / 793178a |
| Default Java | 1.7.0_111 |
| compile | 
https://builds.apache.org/job/PreCommit-AVRO-Build-TEST/14/artifact/patchprocess/compile--lang_java.txt
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-AVRO-Build-TEST/14/artifact/patchprocess/javadoc--lang_java.txt
 |
| compile | 
https://builds.apache.org/job/PreCommit-AVRO-Build-TEST/14/artifact/patchprocess/compile--lang_java.txt
 |
| javac | 
https://builds.apache.org/job/PreCommit-AVRO-Build-TEST/14/artifact/patchprocess/compile--lang_java.txt
 |
| whitespace | 
https://builds.apache.org/job/PreCommit-AVRO-Build-TEST/14/artifact/patchprocess/whitespace-eol.txt
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-AVRO-Build-TEST/14/artifact/patchprocess/javadoc--lang_java.txt
 |
| modules | C: lang/java U: lang/java |
| Console output | 
https://builds.apache.org/job/PreCommit-AVRO-Build-TEST/14/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> Report specific location of schema incompatibilities
> ----------------------------------------------------
>
>                 Key: AVRO-2003
>                 URL: https://issues.apache.org/jira/browse/AVRO-2003
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.8.1
>         Environment: Any java env
>            Reporter: Elliot West
>            Assignee: Elliot West
>            Priority: Minor
>             Fix For: 1.9.0
>
>         Attachments: AVRO-2003.patch
>
>
> h2. Overview
> Building on the work to improve schema incompatibility reporting in 
> AVRO-1933, it would be useful if the {{SchemaCompatibility}} classes could 
> also report the location in the schema where any incompatibility was 
> encountered.
> It is recommended that the location reported is both easily readable by 
> humans and machines. In the first case this would assist schema developers to 
> pin-point issues in there schema documents, and in the latter case it 
> provides a useful mechanism to schema tooling, such as IDEs and editors, to 
> easily select the pertinent nodes in the Schema document tree.
> h2. Implementation specifics
> To meet this requirements it is suggested that the location is encoded using 
> the [JSON Pointer specification|https://tools.ietf.org/html/rfc6901]. This is 
> both easily parsed by users, but is also supported by a number of libraries 
> for a range of common programming languages and platforms.
> h2. Examples
> Given the following example schema, consider some incompatibility scenarios. 
> For each case an expected JSON Pointer description of the incompatibility 
> location is described:
> {code}
> {
>   "type": "record",
>   "name": "myRecord",
>   "fields" : [
>     {"name": "pField", "type": "long"},
>     {"name": "uField", "type":
>       ["null", "int", "string"]
>     },
>     {"name": "eField", "type": 
>       { "type": "enum", "name": "Suit", "symbols" : ["SPADES", "HEARTS", 
> "DIAMONDS", "CLUBS"] }
>     },
>     {"name": "aField", "type":
>       {"type": "array", "items": "string"}
>     },
>     {"name": "mField", "type": 
>       {"type": "map", "values": "long"}
>     },
>     {"name": "fField", "type": 
>       {"type": "fixed", "size": 16, "name": "md5"}
>     }
>   ]
> }
> {code}
> Possible incompatibility scenarions and the location that would be reported 
> back to the user/tool: 
> * Root type incompatibility; report location: {{/}}
> * Record name mismatch; report location: {{/name}}
> * {{pField}} type incompatibility; report location: {{/fields/0/type}}
> * {{uField}} field type incompatibility; report location: {{/fields/1/type}}
> * {{uField}} missing union branch {{string}}; report location: 
> {{/fields/1/type/2}}
> * {{eField}} field type incompatibility; report location: {{/fields/2/type}}
> * {{eField}} missing enum symbol; report location: {{/fields/2/type/symbols}}
> * {{eField}} enum name mismatch; report location: {{/fields/2/type/name}}
> * {{aField}} field type incompatibility; report location: {{/fields/3/type}}
> * {{aField}} array element type incompatibility; report location: 
> {{/fields/3/type/items}}
> * {{mField}} field type incompatibility; report location: {{/fields/4/type}}
> * {{mField}} map value type incompatibility; report location: 
> {{/fields/4/type/values}}
> * {{fField}} field type incompatibility; report location: {{/fields/5/type}}
> * {{fField}} fixed name mismatch; report location: {{/fields/5/type/name}}
> * {{fField}} fixed size type incompatibility; report location: 
> {{/fields/5/type/size}}
> * {{fField}} missing default value; report location: {{/fields/5}}
> h2. Notes
> * This ticket depends on AVRO-1933 and associated patches.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to