GitHub user takluyver opened a pull request:

    https://github.com/apache/avro/pull/234

    Use python-modernize to make py code Python 3 compatible

    As discussed in #133.
    
    This still passes the tests with Python 2, but I can't work out how to test 
with Python 3 - running `ant -Dpython=python3 test` hangs at this point:
    
    ```
    test_tether_word_count.py
    Modules: 
'test_datafile','test_datafile','test_io','test_ipc','test_protocol','test_schema','test_script','test_tether_task','test_tether_task_runner','test_tether_word_count'
    Non-null modules arg. creating script
    pythonpath: 
/home/takluyver/Code/avro/lang/py/build/src:/home/takluyver/Code/avro/lang/py/build/test:/home/takluyver/Code/avro/lang/py/build/lib
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/takluyver/avro py-modernize

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/avro/pull/234.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #234
    
----
commit fb2c64ef9bd840b6fad8da0b1dab88e0ddb3e29c
Author: Thomas Kluyver <[email protected]>
Date:   2017-07-04T13:50:01Z

    Run python-modernize print syntax fixer

commit 690eda9306bde7358ae81bbdfe44df0575e911bc
Author: Thomas Kluyver <[email protected]>
Date:   2017-07-04T13:55:42Z

    Run python-modernize fix_xrange_six fixer

commit a5da1eaef9ca48f55be1c41321ac8f749a06b77a
Author: Thomas Kluyver <[email protected]>
Date:   2017-07-04T14:00:39Z

    Run 2to3 except syntax fixer

commit 59d5a6dba6b67cf7628e01c4d484217b07711803
Author: Thomas Kluyver <[email protected]>
Date:   2017-07-04T14:04:29Z

    Run 2to3 numeric literals syntax fixer

commit b78d12f03fee69fff8c3c218d03ed0aab7178888
Author: Thomas Kluyver <[email protected]>
Date:   2017-07-04T14:06:07Z

    Run python-modernize unicode type fixer

commit 53d7496cfff817448f34a5f7086ceba75ee2cf40
Author: Thomas Kluyver <[email protected]>
Date:   2017-07-04T14:07:30Z

    Run python-modernize basestring fixer

commit 1408ed61164cccf8a7f4d0fd4db4991bec3e806c
Author: Thomas Kluyver <[email protected]>
Date:   2017-07-04T14:10:54Z

    Some manual fixes for use of 'long' type

commit ac975103d1d90960476d06492ba1954bb44fafba
Author: Thomas Kluyver <[email protected]>
Date:   2017-07-04T14:12:31Z

    Run python-modernize file fixer

commit 30ade2c3abd86404d1bdce76dff9a75e9357e94f
Author: Thomas Kluyver <[email protected]>
Date:   2017-07-04T14:19:10Z

    Modernize avro script

commit 956342dc8135af5031a15ce0fac884ff635d02aa
Author: Thomas Kluyver <[email protected]>
Date:   2017-07-04T14:23:54Z

    Manually add self to method signature

commit 1cadf134dc6811578189b0c442b20969375cf485
Author: Thomas Kluyver <[email protected]>
Date:   2017-07-04T14:25:34Z

    Run python-modernize raise_six fixer

commit 976a788750e641d14f3dafd3df851a1bfb96d66c
Author: Thomas Kluyver <[email protected]>
Date:   2017-07-04T14:42:17Z

    Run python-modernize imports_six fixer

commit a3809fc50ebe1e8a98d16202dda9680ae11126f2
Author: Thomas Kluyver <[email protected]>
Date:   2017-07-04T14:45:58Z

    Manual changes to StringIO

commit 4098bd4f8454b5751011ab2e7f7926fde9d78eed
Author: Thomas Kluyver <[email protected]>
Date:   2017-07-04T14:49:09Z

    Run 2to3 has_key fixer

commit 5433612acc2d73ccef3d84e047466d09f2f05109
Author: Thomas Kluyver <[email protected]>
Date:   2017-07-04T14:54:56Z

    Manual change StringIO to BytesIO

commit 897ef282af0465ecc98d51ac61bfde5012ba7ca9
Author: Thomas Kluyver <[email protected]>
Date:   2017-07-04T14:58:24Z

    Run python-modernize dict_six fixer

commit 923abc281117d8b43d414a0ca0a756a903aaceca
Author: Thomas Kluyver <[email protected]>
Date:   2017-07-04T15:01:47Z

    manually fix md5 hashing

commit 55dfeae5c15e13edd6267043864014ae8a1c68b0
Author: Thomas Kluyver <[email protected]>
Date:   2017-07-04T15:03:34Z

    Manual change StringIO to BytesIO

commit b626da66e7ba1ec62a9c6050f033cfb8b1833e43
Author: Thomas Kluyver <[email protected]>
Date:   2017-07-04T15:40:39Z

    Use BytesIO.getvalue() instead of BytesIO.read()
    
    Doesn't affect the position

commit 7cb3e55f577b0d587cc32d64c4c6c95bba701d55
Author: Thomas Kluyver <[email protected]>
Date:   2017-07-04T15:47:45Z

    Compat functions for converting integer to byte string

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to