[
https://issues.apache.org/jira/browse/AVRO-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181892#comment-16181892
]
ASF GitHub Bot commented on AVRO-1047:
--------------------------------------
GitHub user mkw opened a pull request:
https://github.com/apache/avro/pull/250
AVRO-1047: Java: Fix remaining javac warnings.
AVRO-1913 fixed most warnings, but missed a few unchecked usages and left
in some redundant casts. This patch eliminates remaining warnings even with
the `-Xlint:all` flag added to javac. With no more warnings to surpress, the
`@SuppressWarnings("all")` annotation isremoved from the generated code, as
well.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mkw/avro java-warnings
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/avro/pull/250.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #250
----
commit 9c76fb6fa39aad3f6da1f20f3adca8eb01d5b4f1
Author: Michael K. Werle <[email protected]>
Date: 2017-09-27T02:12:20Z
AVRO-1047: Java: Fix remaining javac warnings.
AVRO-1913 fixed most warnings, but missed a few unchecked usages and
left in some redundant casts. This patch eliminates remaining
warnings even with the -Xlint:all flag added to javac. With no more
warnings to surpress, the @SuppressWarnings("all") annotation is
removed from the generated code, as well.
----
> Generated Java classes for specific records contain unchecked casts
> -------------------------------------------------------------------
>
> Key: AVRO-1047
> URL: https://issues.apache.org/jira/browse/AVRO-1047
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.6.3
> Reporter: Garrett Wu
> Attachments: AVRO-1047.patch, suppress-warnings.tar.gz
>
>
> The generated Java classes for specific records cause compiler warnings using
> Oracle/Sun Java 1.6, since it doesn't support @SuppressWarnings("all").
> Instead could we change it to @SuppressWarnings("unchecked")? Only
> "unchecked" and "deprecation" are mentioned Java Language Specification --
> the rest are specific to compiler vendors.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
