[ 
https://issues.apache.org/jira/browse/AVRO-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363258#comment-16363258
 ] 

ASF GitHub Bot commented on AVRO-1940:
--------------------------------------

moriarty commented on issue #146: AVRO-1940: C++: scope enums into own 
namespaces
URL: https://github.com/apache/avro/pull/146#issuecomment-365445172
 
 
   I made the request in AVRO-1940. it was for either scoped enums OR c++11 
enums.
   
   But in general the avrocpp doesn't seem to use C++11 so I just went with 
scoped enums.
   I think there is another issue for C++11 support.
   
   Which is why the commit message says there is another way to do this, but 
would require more changes.
   
   #142 addresses AVRO-1936.
   #146 addresses AVRO-1940.
   
   They should be one commit each.
   
   This GitHub pull request show's a few confusing "@moriarty pushed a commit 
that referenced this pull request" but those are because I've pushed my two 
pull requests #142 and (this) #146 into a topic to further test these patches, 
which we're applying in production for some time, because there was no reply to 
this pull request from Oct 2016 until May 2017.
   
   We then did get some feedback, but I haven't had a chance to figure out how 
to test the compile time option.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> avrogencpp, scoped enums or c++11 enum class
> --------------------------------------------
>
>                 Key: AVRO-1940
>                 URL: https://issues.apache.org/jira/browse/AVRO-1940
>             Project: Avro
>          Issue Type: Improvement
>          Components: c++
>            Reporter: Alexander Moriarty
>            Assignee: Alexander Moriarty
>            Priority: Major
>
> It would be nice if avrogencpp could generated scoped enums.
> Either with C++11 enum class or just adding an additional namespace.
> This sort of relates to the issue I opened a few days ago: #AVRO-1936 in that 
> one way this has been gotten around in the existing AvrogencppTests.cc is by 
> generating one namespace per schema.
> This of course could be a breaking change depending how it is implemented.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to