Looks good. I'll add them to my review backlog and update the relevant JIRA if there's an issue.
On Tue, Apr 17, 2018 at 5:00 PM, Roy Lenferink <rlenfer...@apache.org> wrote: > Hi Sean, > > Thanks for you response. > > I just created 2 JIRA issues, 1 for the introduction of the event-banner > and 1 for the change of the footer statement. > Both the jira issues can be found here [1] [2] > > Is this enough for the Avro community to get the changes applied to the > website? > > Roy > > [1] https://issues.apache.org/jira/browse/AVRO-2170 > [2] https://issues.apache.org/jira/browse/AVRO-2171 > > 2018-04-17 21:26 GMT+01:00 Sean Busbey <bus...@cloudera.com>: > > > Hi Roy! > > > > Please provide a patch on a JIRA issue and we'll take a look. > > > > Thanks for your interest. > > > > On Tue, Apr 17, 2018 at 2:32 PM, Roy Lenferink <rlenfer...@apache.org> > > wrote: > > > > > Hi all, > > > > > > I came to the Apache Avro project to update the website to add a banner > > for > > > the latest apache events. > > > This is as a follow up for the e-mail Rich Bowen sent [1] > > > > > > I think the best position to place such a banner is in the div with id > > > "credit2". It looks good to me to update the <div id="credit2"></div> > to > > > include the following piece of html: > > > <a href="https://www.apache.org/events/current-event.html"><img src=" > > > https://www.apache.org/events/current-event-125x125.png" > > > style="padding-top:0.5em; "></a> > > > > > > Another thing I noticed while having a look at the website for Apache > > Avro. > > > The footer containers the following copyright statement: > > > Apache Hadoop, Hadoop, Apache, the Apache feather logo, and the Apache > > > Hadoop project logo are either registered trademarks or trademarks of > the > > > Apache Software Foundation in the United States and other countries. > > > > > > It is probably better to have this changed to: > > > Apache Avro, Avro, Apache, the Apache feather logo, and the Apache Avro > > > project logo are either registered trademarks or trademarks of the > Apache > > > Software Foundation in the United States and other countries. > > > > > > As these changes are so small, it is probably easier if a committer > > applied > > > the changes directly instead of providing a patch with changes. If not, > > > please let me know how I can provide this change ;) > > > > > > Cheers, > > > Roy > > > > > > [1] https://lists.apache.org/thread.html/ > d672b1849f6668c0f67ff4c71b20bb > > > b4f56a49a1777607b12643d1dc@%3Cdev.community.apache.org%3E > > > > > > > > > > > -- > > busbey > > > -- busbey