[
https://issues.apache.org/jira/browse/AVRO-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547252#comment-16547252
]
ASF GitHub Bot commented on AVRO-2199:
--------------------------------------
tjwp commented on a change in pull request #320: AVRO-2199: Validate that
field defaults have the correct type
URL: https://github.com/apache/avro/pull/320#discussion_r203220999
##########
File path: lang/ruby/lib/avro/schema.rb
##########
@@ -373,6 +374,18 @@ def to_avro(names=Set.new)
avro['doc'] = doc if doc
end
end
+
+ def validate_default!
Review comment:
Should this method be made private?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Validate that field defaults have the correct type
> ---------------------------------------------------
>
> Key: AVRO-2199
> URL: https://issues.apache.org/jira/browse/AVRO-2199
> Project: Avro
> Issue Type: Improvement
> Components: ruby
> Affects Versions: 1.8.2
> Reporter: Daniel Orner
> Priority: Minor
>
> Currently, on the master branch, when a schema is parsed, it is possible to
> define a field with a type and a default of a totally different type. E.g. if
> the field has type "string", the default can be set to "null".
> I'd like to open a PR which will fix this by running the default through the
> SchemaValidator whenever a new Field is created. See
> [https://github.com/salsify/avro-patches/pull/16]
> cc: [~tjwp]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
