[
https://issues.apache.org/jira/browse/AVRO-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636484#comment-16636484
]
Raymie Stata commented on AVRO-2235:
------------------------------------
I looked at the comment at the top of TestSpecificLogicalTypes and realized
that maybe I shouldn't have updated TestRecordWithLogicalTypes. That comment
reads:
{quote}The classes [TestRecordWithLogicalTypes and
TestRecordWithoutLogicalTypes]should not be re-generated because they test
compatibility of Avro with existing Avro-generated sources. When using classes
generated before AVRO-1684, logical types should not be applied by the read or
write paths. Those files should behave as they did before. At the same time,
[~nkollar] suggested in my (GitHub) pull request for AVRO-2090 that I
regenerate TestRecordForLogicalTypes.
{quote}
So it sounds like this code here is for testing backward compatibility and thus
shouldn't be updated.
At the same time, in my (GitHub) pull request for AVRO-2090, [~nkollar]
suggests that I _do_ regenerate these classes. At this point, I'm not sure
what is the right thing to do. Any suggestions?
> Regenerate TestRecordWithLogicalTypes
> -------------------------------------
>
> Key: AVRO-2235
> URL: https://issues.apache.org/jira/browse/AVRO-2235
> Project: Avro
> Issue Type: Bug
> Components: logical types
> Reporter: Raymie Stata
> Assignee: Raymie Stata
> Priority: Major
>
> TestRecordWithLogicalTypes.java is code that was generated by the specific
> compiler and then moved into the testing code tree. It hasn't been changed
> in a while, although the compiler is evolving. I tried to regenerate it and
> found there is a problem with record_with_logical_types.avsc. I will fix the
> schema file and then regenerate TestRecordWithLogicalTypes and check both in.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
