[
https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640576#comment-16640576
]
ASF GitHub Bot commented on AVRO-2229:
--------------------------------------
Fokko commented on a change in pull request #343: [AVRO-2229] Test using a
Docker image
URL: https://github.com/apache/avro/pull/343#discussion_r223173111
##########
File path: lang/java/avro/build.sh
##########
@@ -15,24 +15,30 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-headline(){
- echo -e
"\e[1;34m#################################################################"
- echo -e "##### $1 \e[1;37m"
- echo -e
"\e[1;34m#################################################################\e[0m"
+set -e # exit on error
+
+function usage {
+ echo "Usage: $0 {test|clean|interop-data-generate|interop-data-test}"
+ exit 1
}
-set -e
+case "$target" in
+ test)
+ mvn -B test
+ ;;
+
+ clean)
+ mvn clean
+ ;;
-for lang in /avro/lang/*/
-do
- headline "Run tests: $lang"
- cd "$lang"
+ interop-data-test)
+ mvn clean
+ ;;
+
+ *)
+ usage
+esac
- if [[ "$lang" = *"c++"* ]]; then
- # The current cpp tests are failing:
- # https://issues.apache.org/jira/projects/AVRO/issues/AVRO-2230
- ./build.sh test || true
- else
- ./build.sh test
- fi
done
+
+exit 0
Review comment:
Thanks, this was a copy-paste from other `build.sh` files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Ability to test using a Docker image
> ------------------------------------
>
> Key: AVRO-2229
> URL: https://issues.apache.org/jira/browse/AVRO-2229
> Project: Avro
> Issue Type: Improvement
> Affects Versions: 1.8.2
> Reporter: Fokko Driesprong
> Assignee: Fokko Driesprong
> Priority: Major
> Fix For: 1.9.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
