[
https://issues.apache.org/jira/browse/AVRO-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648666#comment-16648666
]
ASF GitHub Bot commented on AVRO-2240:
--------------------------------------
kojiromike commented on a change in pull request #347: AVRO-2240 Fix py3 Setup
URL: https://github.com/apache/avro/pull/347#discussion_r224944855
##########
File path: lang/py3/setup.py
##########
@@ -93,10 +94,9 @@ def SetupSources():
)
# Make sure the avro shell script is executable:
- os.chmod(
- path=os.path.join(py3_dir, 'scripts', 'avro'),
- mode=0o777,
- )
+ script = os.path.join(py3_dir, 'scripts', 'avro')
+ os.chmod(script,
+ stat.S_IMODE(os.stat(script).st_mode) | stat.S_IXUSR | stat.S_IXGRP
| stat.S_IXOTH)
Review comment:
I'm not convinced this chmod is necessary at all, but this does what the
comment says.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> egg_info fails for avro-python3 using python2
> ---------------------------------------------
>
> Key: AVRO-2240
> URL: https://issues.apache.org/jira/browse/AVRO-2240
> Project: Avro
> Issue Type: Bug
> Components: python
> Affects Versions: 1.8.2
> Reporter: Luke Zulauf
> Priority: Major
>
> When managing dependencies, the ability to call egg_info on any package is
> especially useful (even if the package is not valid for installation with a
> specific python version).
> For example, pipenv can't build a lockfile in python2 if avro-python3 is
> listed as a dependency (for any python version)
>
> The opposite works (using python3 to check the egg_info of avro (the python2
> version).
>
> {code:java}
> $ python3 avro/setup.py egg_info
> (succeeds)
> $ python2 avro/setup.py egg_info
> (succeeds)
> $ python3 avro-python3/setup.py egg_info
> (succeeds)
> $ python2 avro-python3/setup.py egg_info
> (fails){code}
> It would be great if you didn't raise an assertion error for all usages of
> running setup.py, especially when running egg_info.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
