[
https://issues.apache.org/jira/browse/AVRO-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660776#comment-16660776
]
ASF GitHub Bot commented on AVRO-2241:
--------------------------------------
Fokko commented on issue #346: AVRO-2241. Fix Jsr310/Joda datetime tests
URL: https://github.com/apache/avro/pull/346#issuecomment-432282011
I've updated the tests, and they are green now
```
MacBook-Pro-van-Fokko:avro fokkodriesprong$ mvn -q clean test
[debug] execute contextualize
[debug] execute contextualize
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.avro.TestDataFileCustomSync
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.329 sec -
in org.apache.avro.TestDataFileCustomSync
Running org.apache.avro.TestDataFileDeflate
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.28 sec -
in org.apache.avro.TestDataFileDeflate
Running org.apache.avro.TestSchemaCompatibilityReaderFieldMissingDefaultValue
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.257 sec -
in org.apache.avro.TestSchemaCompatibilityReaderFieldMissingDefaultValue
Running org.apache.avro.specific.TestSpecificData
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.31 sec -
in org.apache.avro.specific.TestSpecificData
Running org.apache.avro.specific.TestSpecificLogicalTypes
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.537 sec -
in org.apache.avro.specific.TestSpecificLogicalTypes
Running org.apache.avro.specific.TestSpecificToFromByteArray
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.373 sec -
in org.apache.avro.specific.TestSpecificToFromByteArray
Running org.apache.avro.TestDataFileCorruption
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.291 sec -
in org.apache.avro.TestDataFileCorruption
Running org.apache.avro.TestDataFile
Tests run: 40, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.944 sec -
in org.apache.avro.TestDataFile
Running org.apache.avro.util.internal.TestJacksonUtils
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.236 sec -
in org.apache.avro.util.internal.TestJacksonUtils
Running org.apache.avro.util.TestCaseFinder
Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.102 sec -
in org.apache.avro.util.TestCaseFinder
Running org.apache.avro.util.TestUtf8
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.062 sec -
in org.apache.avro.util.TestUtf8
Running org.apache.avro.file.TestLengthLimitedInputStream
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.06 sec -
in org.apache.avro.file.TestLengthLimitedInputStream
Running org.apache.avro.file.TestCustomCodec
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.102 sec -
in org.apache.avro.file.TestCustomCodec
Running org.apache.avro.file.TestZstandardCodec
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.073 sec -
in org.apache.avro.file.TestZstandardCodec
Running org.apache.avro.file.TestSeekableByteArrayInput
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.29 sec -
in org.apache.avro.file.TestSeekableByteArrayInput
Running org.apache.avro.file.TestBZip2Codec
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.082 sec -
in org.apache.avro.file.TestBZip2Codec
Running org.apache.avro.file.TestIOExceptionDuringWrite
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.335 sec -
in org.apache.avro.file.TestIOExceptionDuringWrite
Running org.apache.avro.TestReadingWritingDataInEvolvedSchemas
Tests run: 24, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.295 sec -
in org.apache.avro.TestReadingWritingDataInEvolvedSchemas
Running org.apache.avro.TestSchemaCompatibilityMissingUnionBranch
Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.348 sec -
in org.apache.avro.TestSchemaCompatibilityMissingUnionBranch
Running org.apache.avro.reflect.TestByteBuffer
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.864 sec -
in org.apache.avro.reflect.TestByteBuffer
Running org.apache.avro.reflect.TestReflectAllowNulls
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.348 sec -
in org.apache.avro.reflect.TestReflectAllowNulls
Running org.apache.avro.reflect.TestReflectData
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.146 sec -
in org.apache.avro.reflect.TestReflectData
Running org.apache.avro.reflect.TestReflectionUtil
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.072 sec -
in org.apache.avro.reflect.TestReflectionUtil
Running org.apache.avro.reflect.TestReflectLogicalTypes
Tests run: 16, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.407 sec -
in org.apache.avro.reflect.TestReflectLogicalTypes
Running org.apache.avro.reflect.TestReflectDatumReader
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.279 sec -
in org.apache.avro.reflect.TestReflectDatumReader
Running org.apache.avro.reflect.TestNonStringMapKeys
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.509 sec -
in org.apache.avro.reflect.TestNonStringMapKeys
Running org.apache.avro.reflect.TestReflect
Tests run: 65, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.433 sec -
in org.apache.avro.reflect.TestReflect
Running org.apache.avro.io.TestValidatingIO
Tests run: 972, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.641 sec
- in org.apache.avro.io.TestValidatingIO
Running org.apache.avro.io.TestResolvingIO
Tests run: 816, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.704 sec
- in org.apache.avro.io.TestResolvingIO
Running org.apache.avro.io.TestBlockingIO
Tests run: 376, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.189 sec
- in org.apache.avro.io.TestBlockingIO
Running org.apache.avro.io.TestResolvingIOResolving
Tests run: 192, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.376 sec
- in org.apache.avro.io.TestResolvingIOResolving
Running org.apache.avro.io.TestBinaryEncoderFidelity
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.058 sec -
in org.apache.avro.io.TestBinaryEncoderFidelity
Running org.apache.avro.io.TestBinaryDecoder
Tests run: 48, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.332 sec -
in org.apache.avro.io.TestBinaryDecoder
Running org.apache.avro.io.TestEncoders
Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.296 sec -
in org.apache.avro.io.TestEncoders
Running org.apache.avro.io.TestBlockingIO2
Tests run: 84, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.111 sec -
in org.apache.avro.io.TestBlockingIO2
Running org.apache.avro.io.TestJsonDecoder
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.242 sec -
in org.apache.avro.io.TestJsonDecoder
Running org.apache.avro.io.parsing.TestResolvingGrammarGenerator2
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.249 sec -
in org.apache.avro.io.parsing.TestResolvingGrammarGenerator2
Running org.apache.avro.io.parsing.TestResolvingGrammarGenerator
Tests run: 32, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.375 sec -
in org.apache.avro.io.parsing.TestResolvingGrammarGenerator
Running org.apache.avro.message.TestBinaryMessageEncoding
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.297 sec -
in org.apache.avro.message.TestBinaryMessageEncoding
Running org.apache.avro.TestDataFileConcat
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.945 sec -
in org.apache.avro.TestDataFileConcat
Running org.apache.avro.TestSchemaCompatibility
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.319 sec -
in org.apache.avro.TestSchemaCompatibility
Running org.apache.avro.TestDataFileMeta
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.231 sec -
in org.apache.avro.TestDataFileMeta
Running org.apache.avro.TestFixed
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.215 sec -
in org.apache.avro.TestFixed
Running org.apache.avro.TestSchemaCompatibilityFixedSizeMismatch
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.252 sec -
in org.apache.avro.TestSchemaCompatibilityFixedSizeMismatch
Running org.apache.avro.TestDataFileReflect
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.33 sec -
in org.apache.avro.TestDataFileReflect
Running org.apache.avro.TestCircularReferences
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.29 sec -
in org.apache.avro.TestCircularReferences
Running org.apache.avro.TestSchemaBuilder
Tests run: 39, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.352 sec -
in org.apache.avro.TestSchemaBuilder
Running org.apache.avro.TestSchemaNormalization
Tests run: 86, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.267 sec -
in org.apache.avro.TestSchemaNormalization
Running org.apache.avro.TestSchemaCompatibilityNameMismatch
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.255 sec -
in org.apache.avro.TestSchemaCompatibilityNameMismatch
Running org.apache.avro.TestProtocol
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.21 sec -
in org.apache.avro.TestProtocol
Running org.apache.avro.TestSchemaCompatibilityMissingEnumSymbols
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.235 sec -
in org.apache.avro.TestSchemaCompatibilityMissingEnumSymbols
Running org.apache.avro.generic.TestGenericLogicalTypes
Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.328 sec -
in org.apache.avro.generic.TestGenericLogicalTypes
Running org.apache.avro.generic.TestGenericDatumWriter
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.267 sec -
in org.apache.avro.generic.TestGenericDatumWriter
Running org.apache.avro.generic.TestGenericData
Tests run: 30, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.251 sec -
in org.apache.avro.generic.TestGenericData
Running org.apache.avro.generic.TestGenericRecordBuilder
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.231 sec -
in org.apache.avro.generic.TestGenericRecordBuilder
Running org.apache.avro.TestSchemaCompatibilityTypeMismatch
Tests run: 29, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.261 sec -
in org.apache.avro.TestSchemaCompatibilityTypeMismatch
Running org.apache.avro.TestSchema
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.262 sec -
in org.apache.avro.TestSchema
Running org.apache.avro.data.TestTimeConversions
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.316 sec -
in org.apache.avro.data.TestTimeConversions
Running org.apache.avro.data.TestJsr310TimeConversions
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.254 sec -
in org.apache.avro.data.TestJsr310TimeConversions
Running org.apache.avro.TestLogicalType
Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.352 sec -
in org.apache.avro.TestLogicalType
Running org.apache.avro.TestSchemaCompatibilityMultiple
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.315 sec -
in org.apache.avro.TestSchemaCompatibilityMultiple
Running org.apache.avro.TestSchemaValidation
Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.386 sec -
in org.apache.avro.TestSchemaValidation
Running org.apache.avro.TestSchemaCompatibilityEnumDefaults
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.261 sec -
in org.apache.avro.TestSchemaCompatibilityEnumDefaults
Results :
Tests run: 3102, Failures: 0, Errors: 0, Skipped: 1
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix Jsr310/Joda tests when comparing datetimes
> ----------------------------------------------
>
> Key: AVRO-2241
> URL: https://issues.apache.org/jira/browse/AVRO-2241
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.8.2
> Reporter: Fokko Driesprong
> Assignee: Fokko Driesprong
> Priority: Major
> Fix For: 1.9.0
>
>
> Whe comparing Instant, DateTime, LocalTime with its Joda equivalents the
> tests fail since the java.time.* adds support for microseconds, and Joda only
> miliseconds. For example:
> Failed tests:
>
> TestSpecificLogicalTypes.testAbilityToReadJodaRecordWrittenAsJsr310Record:183
> Expected: is "11:45:07.170331"
> but: was "11:45:07.170"
> TestSpecificLogicalTypes.testRecordWithJsr310LogicalTypes:115 Should match
> written record expected:<{"b": true, "i32": 34, "i64": 35, "f32": 3.14,
> "f64": 3019.34, "s": null, "d": 2018-10-11, "t": 11:45:06.513252, "ts":
> 2018-10-11T11:45:06.513358Z, "dec": 123.45}> but was:<{"b": true, "i32": 34,
> "i64": 35, "f32": 3.14, "f64": 3019.34, "s": null, "d": 2018-10-11, "t":
> 11:45:06.513, "ts": 2018-10-11T11:45:06.513Z, "dec": 123.45}>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
