[
https://issues.apache.org/jira/browse/AVRO-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16666619#comment-16666619
]
ASF GitHub Bot commented on AVRO-1887:
--------------------------------------
kojiromike commented on a change in pull request #353: AVRO-1887 Integrate Yetus
URL: https://github.com/apache/avro/pull/353#discussion_r228773024
##########
File path: share/test/interop/bin/test_rpc_interop.sh
##########
@@ -21,29 +21,33 @@ cd `dirname "$0"`/../../../.. # connect to root
VERSION=`cat share/VERSION.txt`
-#set -x # echo commands
+set -x # echo commands
java_client="java -jar lang/java/tools/target/avro-tools-$VERSION.jar rpcsend"
java_server="java -jar lang/java/tools/target/avro-tools-$VERSION.jar
rpcreceive"
py_client="python lang/py/build/src/avro/tool.py rpcsend"
py_server="python lang/py/build/src/avro/tool.py rpcreceive"
-ruby_client="ruby -rubygems -Ilang/ruby/lib lang/ruby/test/tool.rb rpcsend"
-ruby_server="ruby -rubygems -Ilang/ruby/lib lang/ruby/test/tool.rb rpcreceive"
+#ruby_client="ruby -rubygems -Ilang/ruby/lib lang/ruby/test/tool.rb rpcsend"
+#ruby_server="ruby -rubygems -Ilang/ruby/lib lang/ruby/test/tool.rb rpcreceive"
export PYTHONPATH=lang/py/build/src # path to avro Python module
-clients=("$java_client" "$py_client" "$ruby_client")
-servers=("$java_server" "$py_server" "$ruby_server")
+#clients=("$java_client" "$py_client" "$ruby_client")
+#servers=("$java_server" "$py_server" "$ruby_server")
+clients=("$java_client" "$py_client")
+servers=("$java_server" "$py_server")
proto=share/test/schemas/simple.avpr
portfile=/tmp/interop_$$
function cleanup() {
rm -rf $portfile
Review comment:
Please quote this expansion. An unquoted expansion after `rm -rf` is
dangerous.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> set up precommit checks via Apache Yetus
> ----------------------------------------
>
> Key: AVRO-1887
> URL: https://issues.apache.org/jira/browse/AVRO-1887
> Project: Avro
> Issue Type: Task
> Components: build, community
> Reporter: Sean Busbey
> Assignee: Suraj Acharya
> Priority: Blocker
> Attachments: AVRO-1887-0.patch, AVRO-1887-1.patch, AVRO-1887-2.patch
>
>
> The lack of automated checks for things like doing a full build is negatively
> impacting my ability to do timely reviews. We should leverage the work done
> by other communities and get precommit checks going with Apache Yetus ([ref
> Apache Yetus
> Precommit|http://yetus.apache.org/documentation/0.3.0/precommit-basic/])
> Yetus has built in support for using Docker as a containerized build
> environment ([ref
> docs|https://yetus.apache.org/documentation/0.3.0/precommit-advanced/#Docker_Support]),
> but I don't know if we can use the one we have directly or if we'll need to
> do some refactoring.
> Implementing this will ultimately require a committer (so that they can make
> changes to builds.apache.org), but a non-cmmitter can get the bulk of the
> work done by managing to do local yetus checks with the docker feature active.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
