[ 
https://issues.apache.org/jira/browse/AVRO-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16672153#comment-16672153
 ] 

ASF GitHub Bot commented on AVRO-2208:
--------------------------------------

dkulp closed pull request #325: AVRO-2208 Unneeded OSGi import generated for 
Guava dependency
URL: https://github.com/apache/avro/pull/325
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/lang/java/avro/pom.xml b/lang/java/avro/pom.xml
index bf12ebb15..eff144a57 100644
--- a/lang/java/avro/pom.xml
+++ b/lang/java/avro/pom.xml
@@ -37,6 +37,7 @@
   <properties>
     <osgi.import>
       !org.apache.avro*,
+      !com.google.common*,
       com.thoughtworks.paranamer,
       org.codehaus.jackson*,
       org.xerial.snappy;resolution:=optional,


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unneeded OSGi import generated for Guava dependency
> ---------------------------------------------------
>
>                 Key: AVRO-2208
>                 URL: https://issues.apache.org/jira/browse/AVRO-2208
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.8.2
>            Reporter: Arnoud Glimmerveen
>            Priority: Major
>             Fix For: 1.9.0
>
>
> The classes from Guava used by Avro are shaded into the final jar, however 
> the OSGi imports are calculated before shading, resulting in a 
> com.google.common* dependency declared in Import-Package manifest header. As 
> a consequence in an OSGi environment one has to install a version of Guava 
> even though that version will not be used by Avro.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to