[
https://issues.apache.org/jira/browse/AVRO-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678770#comment-16678770
]
ASF GitHub Bot commented on AVRO-1695:
--------------------------------------
Fokko commented on issue #116: AVRO-1695: Ruby support for logical types
revisited
URL: https://github.com/apache/avro/pull/116#issuecomment-436776740
@tjwp Travis is still not happy, can you take a peek?
```
.................../testptch/unknown/lang/ruby/lib/avro/schema.rb:318:
warning: too many arguments for format string
..........................F
===============================================================================
Failure: test_timestamp_micros_long_conversion(TestLogicalTypes)
/testptch/unknown/lang/ruby/test/test_logical_types.rb:83:in
`test_timestamp_micros_long_conversion'
80:
81: now = Time.now.utc
82:
=> 83: assert_equal now, type.decode(type.encode(now))
84: assert_equal 1432849613221843, type.encode(Time.utc(2015, 5,
28, 21, 46, 53, 221843))
85: assert_equal 1432849613221843, type.encode(DateTime.new(2015,
5, 28, 21, 46, 53.221843))
86: assert_equal Time.utc(2015, 5, 28, 21, 46, 53, 221843),
type.decode(1432849613221843)
<2018-11-07 20:38:27 UTC> expected but was
<2018-11-07 20:38:27 UTC>
diff:
2018-11-07 20:38:27 UTC
===============================================================================
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add LogicalType support to the Ruby library
> -------------------------------------------
>
> Key: AVRO-1695
> URL: https://issues.apache.org/jira/browse/AVRO-1695
> Project: Avro
> Issue Type: New Feature
> Components: ruby
> Reporter: Daniel Schierbeck
> Priority: Major
> Fix For: 1.9.0
>
>
> It would be nice if the Ruby library had feature parity. I would be willing
> to contribute work if someone could review and merge the code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
