[
https://issues.apache.org/jira/browse/AVRO-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678825#comment-16678825
]
ASF GitHub Bot commented on AVRO-2234:
--------------------------------------
Fokko commented on issue #337: AVRO-2234 Use MappingProxyType, not ImmutableDict
URL: https://github.com/apache/avro/pull/337#issuecomment-436789422
@kojiromike Check. I needed extra permissions to add you as to the Jira.
Should be set now! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Use native MappingProxyType instead of hand-written ImmutableDict
> -----------------------------------------------------------------
>
> Key: AVRO-2234
> URL: https://issues.apache.org/jira/browse/AVRO-2234
> Project: Apache Avro
> Issue Type: Improvement
> Components: python
> Reporter: Michael A. Smith
> Priority: Major
> Fix For: 1.9.0
>
>
> Per the rejection notice in
> [PEP-416,|https://www.python.org/dev/peps/pep-0416/] there is no native
> ImmutableDict in Python. However, there is a MappingProxyType that makes a
> proxy to the mapping of a dictionary, and is fully native. For most purposes,
> including avro's, it's a fully suitable replacement for a real ImmutableDict
> implementation (except for a minor detail about JSON encoding that is easier
> to solve and support than maintaining a complete implementation of
> ImmutableDict.)
> I propose that we drop ImmutableDict and replace it with MappingProxyType.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
