[
https://issues.apache.org/jira/browse/AVRO-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697638#comment-16697638
]
ASF GitHub Bot commented on AVRO-2271:
--------------------------------------
thiru-apache commented on issue #387: AVRO-2271: C++ Support for Custom Fields
URL: https://github.com/apache/avro/pull/387#issuecomment-441342983
Instead of having a new class `CustomFields` can we not define a simple
`typedef`?
typedef std::map<std::string, json::Entity>
There is a little bit check done in `addCustomField()` member of the new
class. That can be moved into its caller namely `addCustomField()` of `Node`.
At @gioragutt has mentioned, the code needs to compile under pre-2011
compilers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> C++ Support for Custom Fields
> ------------------------------
>
> Key: AVRO-2271
> URL: https://issues.apache.org/jira/browse/AVRO-2271
> Project: Apache Avro
> Issue Type: Bug
> Components: c++
> Affects Versions: 1.8.2
> Reporter: Aniket Mokashi
> Assignee: Aniket Mokashi
> Priority: Major
>
> To support following schemas:
>
> {noformat}
> R"({"type": "string", "logicalType": "foo", "sqlType": "datetime"})",
> R"({"type": "bytes", "logicalType": "decimal", "precision": 12, "scale": 6,
> "sqlType": "datetime"})",
> R"({"type": "null", "extra attribute": "custom field"})",
> R"({"type": "boolean", "extra1": 1, "extra2": 2, "extra3": 3})",
> R"({"type": "fixed", "name": "Test", "size": 1, "extra attribute": 1})",
> R"(["null", \{"type": "string", "extra attribute": "custom field"}])",
> R"([\{"type": "string", "extra attribute": "custom field"}, "null"])",
> {noformat}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
