[
https://issues.apache.org/jira/browse/AVRO-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698732#comment-16698732
]
ASF GitHub Bot commented on AVRO-2238:
--------------------------------------
tjwp commented on issue #390: AVRO-2238 Move to up to OpenJDK image
URL: https://github.com/apache/avro/pull/390#issuecomment-441593629
@Fokko I'd love to get those warnings cleaned up but I don't think they are
anything new. I usually test across ruby versions from 1.9.3 to 2.5.3 and get
warnings from all of them but the tests still pass. Testing across all the ruby
versions that Avro supports is something that I'd also like to add to the build.
The ruby tests are passing for this build (from the Travis run for this PR):
```
Finished in 0.548804206 seconds.
-------------------------------------------------------------------------------
126 tests, 1221 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0
notifications
100% passed
-------------------------------------------------------------------------------
229.59 tests/s, 2224.84 assertions/s
```
It looks like it is the start of the PHP tests that is failing:
```
EEEEEEEEEPHP Fatal error: Declaration of
SebastianBergmann\Comparator\DOMNodeComparator::assertEquals($expected,
$actual, $delta = 0, $canonicalize = false, $ignoreCase = false) must be
compatible with
SebastianBergmann\Comparator\ObjectComparator::assertEquals($expected, $actual,
$delta = 0, $canonicalize = false, $ignoreCase = false, array &$processed =
Array) in /usr/share/php/SebastianBergmann/Comparator/DOMNodeComparator.php on
line 110
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Update Docker image from java to openjdk
> ----------------------------------------
>
> Key: AVRO-2238
> URL: https://issues.apache.org/jira/browse/AVRO-2238
> Project: Apache Avro
> Issue Type: Improvement
> Components: docker
> Reporter: Fokko Driesprong
> Priority: Major
>
> Currently the docker image to run the tests is still using java which is
> deprecated: https://hub.docker.com/_/java/
> Therefore we should move to openjdk (https://hub.docker.com/_/openjdk/).
> Starting with version 8, and also adding 10 and 11 to it to make sure that
> Avro is compatible with future version of Java.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
