[ 
https://issues.apache.org/jira/browse/AVRO-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701562#comment-16701562
 ] 

ASF GitHub Bot commented on AVRO-2276:
--------------------------------------

iemejia commented on a change in pull request #394: AVRO-2276: Escape Map keys 
in GenericData.toString to generate valid JSON
URL: https://github.com/apache/avro/pull/394#discussion_r236992017
 
 

 ##########
 File path: lang/java/grpc/pom.xml
 ##########
 @@ -87,6 +92,12 @@
       <!-- use netty only for tests as user can use grpc transports other than 
Netty -->
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>io.netty</groupId>
+      <artifactId>netty-codec-http2</artifactId>
+      <version>${netty-codec-http2.version}</version>
+      <scope>test</scope>
+    </dependency>
 
 Review comment:
   It does, apparently grpc has some implicit dependencies that both IntelliJ 
(2018.3) and Maven 3.5.4 aren't happy with in windows, so we need to set them 
explicit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> GenericData.toString does not always generate valid JSON for Map datum
> ----------------------------------------------------------------------
>
>                 Key: AVRO-2276
>                 URL: https://issues.apache.org/jira/browse/AVRO-2276
>             Project: Apache Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.9.0
>            Reporter: Ismaël Mejía
>            Assignee: Ismaël Mejía
>            Priority: Minor
>
> Avro represents data as json internally so it requires to escape the keys of 
> the objects (Maps) as mandated by https://tools.ietf.org/html/rfc8259
> I discover this while running a build on windows because of '\' characters. 
> But it can be easily reproduced on linux creating a file/dir with backspaces.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to