[
https://issues.apache.org/jira/browse/AVRO-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703569#comment-16703569
]
ASF GitHub Bot commented on AVRO-2279:
--------------------------------------
dkulp closed pull request #397: AVRO-2279: Fix broken java build on windows
URL: https://github.com/apache/avro/pull/397
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.gitignore b/.gitignore
index 83e7336c3..edb7931ce 100644
--- a/.gitignore
+++ b/.gitignore
@@ -16,3 +16,4 @@ test-output
/lang/java/compiler/nbactions.xml
/lang/java/compiler/nb-configuration.xml
/lang/java/compiler/nbproject/
+**/.vscode/**/*
diff --git a/lang/java/grpc/pom.xml b/lang/java/grpc/pom.xml
index a64d8cd54..97dfe3671 100644
--- a/lang/java/grpc/pom.xml
+++ b/lang/java/grpc/pom.xml
@@ -75,6 +75,11 @@
</build>
<dependencies>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-core</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-stub</artifactId>
@@ -87,6 +92,12 @@
<!-- use netty only for tests as user can use grpc transports other than
Netty -->
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-codec-http2</artifactId>
+ <version>${netty-codec-http2.version}</version>
+ <scope>test</scope>
+ </dependency>
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>avro</artifactId>
diff --git a/lang/java/maven-plugin/pom.xml b/lang/java/maven-plugin/pom.xml
index e09222192..3ebba528e 100644
--- a/lang/java/maven-plugin/pom.xml
+++ b/lang/java/maven-plugin/pom.xml
@@ -33,10 +33,6 @@
<name>Apache Avro Maven Plugin</name>
<description>Maven plugin for Avro IDL and Specific API
Compilers</description>
- <prerequisites>
- <maven>${maven.version}</maven>
- </prerequisites>
-
<properties>
<pluginTestingVersion>1.3</pluginTestingVersion>
</properties>
diff --git a/lang/java/pom.xml b/lang/java/pom.xml
index 6a426fe39..773d71c5e 100644
--- a/lang/java/pom.xml
+++ b/lang/java/pom.xml
@@ -62,6 +62,7 @@
<hamcrest.version>1.3</hamcrest.version>
<joda.version>2.10.1</joda.version>
<grpc.version>1.16.1</grpc.version>
+ <netty-codec-http2.version>4.1.30.Final</netty-codec-http2.version>
<findbugs-annotations.version>1.3.9-1</findbugs-annotations.version>
<zstd-jni.version>1.3.7-1</zstd-jni.version>
@@ -79,7 +80,7 @@
<surefire-plugin.version>2.22.1</surefire-plugin.version>
<file-management.version>1.2.1</file-management.version>
<shade-plugin.version>3.2.0</shade-plugin.version>
- <archetype-plugin.version>2.4</archetype-plugin.version>
+ <archetype-plugin.version>3.0.1</archetype-plugin.version>
</properties>
<modules>
@@ -513,6 +514,11 @@
<artifactId>joda-time</artifactId>
<version>${joda.version}</version>
</dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-core</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-stub</artifactId>
@@ -523,6 +529,11 @@
<artifactId>grpc-netty</artifactId>
<version>${grpc.version}</version>
</dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-codec-http2</artifactId>
+ <version>${netty-codec-http2.version}</version>
+ </dependency>
<dependency>
<groupId>com.github.luben</groupId>
<artifactId>zstd-jni</artifactId>
diff --git a/lang/java/protobuf/pom.xml b/lang/java/protobuf/pom.xml
index 313ab2508..8ead26e0e 100644
--- a/lang/java/protobuf/pom.xml
+++ b/lang/java/protobuf/pom.xml
@@ -50,6 +50,7 @@
<plugins>
<plugin>
<artifactId>maven-antrun-plugin</artifactId>
+ <version>${antrun-plugin.version}</version>
<executions>
<execution>
<phase>generate-test-sources</phase>
diff --git a/lang/java/thrift/pom.xml b/lang/java/thrift/pom.xml
index ce3c591d0..f98f09ec6 100644
--- a/lang/java/thrift/pom.xml
+++ b/lang/java/thrift/pom.xml
@@ -50,6 +50,7 @@
<plugins>
<plugin>
<artifactId>maven-antrun-plugin</artifactId>
+ <version>${antrun-plugin.version}</version>
<executions>
<execution>
<phase>generate-test-sources</phase>
diff --git a/lang/java/tools/pom.xml b/lang/java/tools/pom.xml
index 17e019527..d7e94e99e 100644
--- a/lang/java/tools/pom.xml
+++ b/lang/java/tools/pom.xml
@@ -50,6 +50,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
+ <version>${source-plugin.version}</version>
<configuration>
<excludes>
<exclude>META-INF/LICENSE</exclude>
diff --git a/pom.xml b/pom.xml
index 0792baaa1..7577fbc29 100644
--- a/pom.xml
+++ b/pom.xml
@@ -20,7 +20,7 @@
<modelVersion>4.0.0</modelVersion>
<prerequisites>
- <maven>2.2.1</maven>
+ <maven>3.0.5</maven>
</prerequisites>
<parent>
@@ -51,10 +51,13 @@
<apache-rat-tasks.version>0.7</apache-rat-tasks.version>
<!-- plugin versions -->
- <antrun-plugin.version>1.7</antrun-plugin.version>
+ <antrun-plugin.version>1.8</antrun-plugin.version>
<enforcer-plugin.version>1.3.1</enforcer-plugin.version>
<rat.version>0.13</rat.version>
- <checkstyle-plugin.version>2.17</checkstyle-plugin.version>
+ <checkstyle-plugin.version>3.0.0</checkstyle-plugin.version>
+ <gpg-plugin.version>1.6</gpg-plugin.version>
+ <javadoc-plugin.version>3.0.1</javadoc-plugin.version>
+ <source-plugin.version>3.0.1</source-plugin.version>
</properties>
<modules>
@@ -132,6 +135,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
+ <version>${javadoc-plugin.version}</version>
<executions>
<execution>
<!-- build javadoc jars per jar for publishing to maven -->
@@ -157,6 +161,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
+ <version>${source-plugin.version}</version>
<executions>
<execution>
<!-- builds source jars and attaches them to the project for
publishing -->
@@ -190,6 +195,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId>
+ <version>${gpg-plugin.version}</version>
<executions>
<execution>
<id>sign-artifacts</id>
@@ -272,6 +278,7 @@
<exclude>lang/c/tests/schema_tests/fail/*</exclude> <!-- C
test cases -->
<exclude>lang/c/tests/schema_tests/pass/*</exclude> <!-- C
test cases -->
<exclude>lang/c++/jsonschemas/*</exclude> <!-- C++ test cases
-->
+ <exclude>lang/js/test/dat/**</exclude>
<!-- IDE settings and files -->
<exclude>**/.classpath</exclude>
<exclude>**/.project</exclude>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Build is broken in windows
> --------------------------
>
> Key: AVRO-2279
> URL: https://issues.apache.org/jira/browse/AVRO-2279
> Project: Apache Avro
> Issue Type: Improvement
> Components: build, java
> Affects Versions: 1.9.0
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
>
> Current Java build does not complete while doing a simple mvn clean install
> -DskipTests on windows.
> This issue tackles fixing any issue in the build but not in the tests (some
> still fail for mapreduce related modules).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
