[
https://issues.apache.org/jira/browse/AVRO-2290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733553#comment-16733553
]
Ismaël Mejía commented on AVRO-2290:
------------------------------------
Great and simple fix, thanks [~dkulp]. Now we are Java 11 compatible Yay !
(well we still need to do update some minor things in the build system + CI).
And then in the future open the discussion on Unsafe support removal (when(if)
Oracle fully does it.
[~Fokko] I created an independent JIRA for CI on Java11 and assigned it to you
(feel free to unassign if you prefer). AVRO-2296
> TestSpecificLogicalTypes.testRecordWithJsr310LogicalTypes breaks on Java 11
> ---------------------------------------------------------------------------
>
> Key: AVRO-2290
> URL: https://issues.apache.org/jira/browse/AVRO-2290
> Project: Apache Avro
> Issue Type: Sub-task
> Components: java
> Reporter: Ismaël Mejía
> Assignee: Daniel Kulp
> Priority: Minor
> Fix For: 1.9.0
>
>
> Java 11 has nano-second precision so the test breaks, the test should now
> detect this and adapt accordingly.
> {code}
> [ERROR]
> testRecordWithJsr310LogicalTypes(org.apache.avro.specific.TestSpecificLo
> gicalTypes) Time elapsed: 0.24 s <<< FAILURE!
> java.lang.AssertionError: Should match written record expected:<{"b": true,
> "i32
> ": 34, "i64": 35, "f32": 3.14, "f64": 3019.34, "s": null, "d": 2018-12-20,
> "t":
> 15:02:53.535103, "ts": 2018-12-20T14:02:53.535127Z, "dec": 123.45}> but
> was:<{"b
> ": true, "i32": 34, "i64": 35, "f32": 3.14, "f64": 3019.34, "s": null, "d":
> 2018
> -12-20, "t": 15:02:53.535, "ts": 2018-12-20T14:02:53.535Z, "dec": 123.45}>
> at
> org.apache.avro.specific.TestSpecificLogicalTypes.testRecordWithJsr31
> 0LogicalTypes(TestSpecificLogicalTypes.java:132)
> [ERROR]
> testAbilityToReadJodaRecordWrittenAsJsr310Record(org.apache.avro.specifi
> c.TestSpecificLogicalTypes) Time elapsed: 0.005 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: is "15:02:53.639158"
> but: was "15:02:53.639"
> at
> org.apache.avro.specific.TestSpecificLogicalTypes.testAbilityToReadJo
> daRecordWrittenAsJsr310Record(TestSpecificLogicalTypes.java:204)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
