[ 
https://issues.apache.org/jira/browse/AVRO-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827608#comment-16827608
 ] 

Raman Gupta commented on AVRO-2366:
-----------------------------------

Thanks [~rumeshkrish]... you can see the problem by checking out commit 
3d2666f760b4834bcfdf2d2a96d6a277972d24c7 of  
https://github.com/rocketraman/gradle-avro-plugin 
(https://github.com/rocketraman/gradle-avro-plugin/tree/3d2666f760b4834bcfdf2d2a96d6a277972d24c7).

The failing test case, that worked on 1.8.0, is this one here -- just remove 
the @Ignored annotation:

https://github.com/rocketraman/gradle-avro-plugin/blob/3d2666f760b4834bcfdf2d2a96d6a277972d24c7/src/test/groovy/com/commercehub/gradle/plugin/avro/OptionsFunctionalSpec.groovy#L293

> setValidateDefaults=false does not seem to work
> -----------------------------------------------
>
>                 Key: AVRO-2366
>                 URL: https://issues.apache.org/jira/browse/AVRO-2366
>             Project: Apache Avro
>          Issue Type: Bug
>    Affects Versions: 1.9.0
>            Reporter: Raman Gupta
>            Priority: Major
>
> Followup to AVRO-2035.
> I am testing 1.9 SNAPSHOT. I set `Schema.Parser.setValidateDefaults` to 
> false, and still get a failure at compile-time if the default does not match 
> the schema. For example, a field definition of:
> {"name": "name", "type": "string", "default": null}
> Should this definition succeed if `setValidateDefaults(false)` is called? If 
> not, should the `setValidateDefaults` method just be removed?
> The exception is:
> Caused by: org.apache.avro.AvroTypeException: Invalid default for field name: 
> null not a {"type":"string","avro.java.string":"String"}
>       at org.apache.avro.Schema.validateDefault(Schema.java:1482)
>       at org.apache.avro.Schema.access$300(Schema.java:84)
>       at org.apache.avro.Schema$Field.<init>(Schema.java:493)
>       at org.apache.avro.Schema$Field.<init>(Schema.java:485)
>       at org.apache.avro.Schema$Field.<init>(Schema.java:504)
>       at 
> org.apache.avro.compiler.specific.SpecificCompiler.addStringType(SpecificCompiler.java:689)
>       at 
> org.apache.avro.compiler.specific.SpecificCompiler.addStringType(SpecificCompiler.java:668)
>       at 
> org.apache.avro.compiler.specific.SpecificCompiler.compile(SpecificCompiler.java:598)
>       at 
> org.apache.avro.compiler.specific.SpecificCompiler.compileToDestination(SpecificCompiler.java:527)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to