Happy to review. I checked the changes into the current master. I’m not sure how to rebase (trying to get up to speed on GitHub) but it had the effect of squashing the changes which is probably a good thing. I created a new PR. Github is claiming it is mergeable so I’m hoping it is good to go.
> On Jul 15, 2019, at 5:47 PM, Brian Lachniet <[email protected]> wrote: > > Hey Patrick, thank you! I actually have a draft PR up for this now: > https://github.com/apache/avro/pull/586. I could certainly use a second > pair of eyes on my changes, if you're willing to review them. > > I want to get your Reflect changes in before we try to merge these changes > in, though. I started to merge your reflect changes this past weekend but > screwed up the rebase. Check out my latest comments on your PR > <https://github.com/apache/avro/pull/521#issuecomment-511232910> if you > haven't seen them already. > > On Sun, Jul 14, 2019 at 7:14 PM Patrick Farry <[email protected]> > wrote: > >> want some help with this? >> >> On Sun, Jul 14, 2019, 4:56 AM Brian Lachniet (JIRA) <[email protected]> >> wrote: >> >>> Brian Lachniet created AVRO-2473: >>> ------------------------------------ >>> >>> Summary: C#: Fix documentation warnings >>> Key: AVRO-2473 >>> URL: https://issues.apache.org/jira/browse/AVRO-2473 >>> Project: Apache Avro >>> Issue Type: Improvement >>> Components: csharp >>> Affects Versions: 1.9.0 >>> Reporter: Brian Lachniet >>> Assignee: Brian Lachniet >>> Fix For: 1.10.0, 1.9.1 >>> >>> >>> Fix the hundreds of documentation warnings in the C# project. These >>> warnings include malformed documentation as well as missing documentation >>> on public members. >>> >>> >>> >>> -- >>> This message was sent by Atlassian JIRA >>> (v7.6.14#76016) >>> >> > > > -- > > [image: 51b630b05e01a6d5134ccfd520f547c4.png] > > Brian Lachniet > > Software Engineer > > E: [email protected] | blachniet.com <http://www.blachniet.com> > > <https://twitter.com/blachniet> <http://www.linkedin.com/in/blachniet>
