[ 
https://issues.apache.org/jira/browse/AVRO-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896961#comment-16896961
 ] 

Andrew Ripa commented on AVRO-2489:
-----------------------------------

[~dkulp]

I've tried both solutions (even after you commit).

1. Adding unistd.h {color:#333333}cause a new error{color}
{code:java}
PATH_TO_WORKSPACE\workspace\avro\avro\lang\c++\test\DataFileTests.cc(27,10): 
error C1083: Cannot open include file: 'unistd.h':
No such file or directory 
[PATH_TO_WORKSPACE\workspace\avro\avro\lang\c++\_build\DataFileTests.vcxproj]{code}
2. Adding thread {color:#333333}and{color} chrono {color:#333333}and replacing 
sleep helped with the build. Only warnings presented now.{color}

{color:#333333}Still, we have errors during test phase:{color}

 
{code:java}
test 8
 Start 8: DataFileTests
8: Test command: 
PATH_TO_WORKSPACE\workspace\avro\avro\lang\c++\_build\RelWithDebInfo\DataFileTests.exe
8: Test timeout computed to be: 10000000
8: Running 67 test cases...
8: PATH_TO_WORKSPACE/workspace/avro/avro/lang/c++/test/DataFileTests.cc(479): 
error: in "DataFile tests_ test11.df/DataFileTest__testReaderSplits": check 
actual_count == count has failed [0 != 1000]
8:
8: *** 1 failure is detected in the test module "Master Test Suite"
 8/11 Test #8: DataFileTests ....................***Failed 2.36 sec
{code}
I assume it should be solved in a separate task. All other tests passed. Tested 
on 'RelWithDebInfo' and 'Release' build types

 

> Build error C3861:  'sleep': identifier not found
> -------------------------------------------------
>
>                 Key: AVRO-2489
>                 URL: https://issues.apache.org/jira/browse/AVRO-2489
>             Project: Apache Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.9.0
>         Environment: Windows Server 2016,
> VS2019,
> cmake 3.15,
> vcpkg 2019.06.26
> Jenkins 2.186
>            Reporter: Andrew Ripa
>            Assignee: Daniel Kulp
>            Priority: Minor
>              Labels: build
>             Fix For: 1.9.1
>
>
> Steps to reproduce:
>  * Fetched 1.9.0 repo 
> [https://github.com/apache/avro/releases/tag/release-1.9.0] from git and  cd 
> to 'lang/c++' folder
>  * Project generated with 
> {code:java}
> mkdir _build
> cd _build
> cmake -G "Visual Studio 16 2019" -A x64 .. -DCMAKE_BUILD_TYPE=Release 
> -DCMAKE_TOOLCHAIN_FILE="PATH_TO_vcpkg.cmake" 
> -DCMAKE_INSTALL_PREFIX="PATH_TO_INSTALL"{code}
>  * Built with
> {code:java}
> cmake --build . --config Release
> {code}
>  * Installed with
> {code:java}
> cmake --build . --config Release --target Install
> {code}
> During the last (install) step received an error
> {noformat}
> PATH_TO_WORKSPACE\workspace\avro\avro\lang\c++\test\DataFileTests.cc(592,13): 
> error C3861:  'sleep': identifier not found 
> [PATH_TO_WORKSPACE\workspace\avro\avro\lang\c++\_build\DataFileTests.vcxproj]{noformat}
>  
> Possible hotfix found 
> [https://social.msdn.microsoft.com/Forums/vstudio/en-US/fdc9d1c3-1082-4c0d-a717-a39313562d4f/sleep?forum=vclanguage]
> Need to change 'sleep(1)' to '{color:#ff0000}*S*{color}leep(1)' in 
> lang/c++/testDataFileTests.cc
>  After that build (and install) completed without errors



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to