I'm fine with merging it into 1.9.1 since it is only the performance tests and no core components of Avro. The impact will be minimal and I would like to keep it Java11 compatible.
It would be nice to introduce some check to capture this in the future. Cheers, Fokko Op wo 21 aug. 2019 om 16:52 schreef Ismaël Mejía <[email protected]>: > Hello, > > I have a question, while checking some Java 11 improvements I > discovered that the Perf module that we introduced in 1.9.0 has a > split package issue that can cause conflicts with Java 11. I was > wondering if we could fix this (the fix is just to isolate the module > classes into its own package), however this is not backwards > compatible with Avro 1.9.0. So should we get this into this release? > or be strict and let it for 1.10.x? > > I just opened the PR for the solution for master (1.10.0) [1] but was > thinking that it is probably worth to cherry pick it and include it in > 1.9.1 even if breaking the previous version compatiblity, because it > is quite new and I expect it has low impact. > > Any opinions? > > [1] https://github.com/apache/avro/pull/615 > > > https://issues.apache.org/jira/browse/AVRO-2517 > > On Wed, Aug 21, 2019 at 11:22 AM Driesprong, Fokko <[email protected]> > wrote: > > > > Thank you Brian, > > > > I'm canceling the RC1 and I'm doing some checks on the 1.9 branch. Seeing > > some funky stuff with the RAT checker. I'll prepare for RC2 this evening. > > > > Cheers, Fokko > > > > > > > > > > Op wo 21 aug. 2019 om 04:17 schreef Brian Lachniet <[email protected] > >: > > > > > It sounds like an rc2 is imminent, but I went ahead and ran some basic > > > checks on the C# bindings. I didn't find anything unusual. I published > > > Apache.Avro > > > v1.9.1-rc1 <https://www.nuget.org/packages/Apache.Avro/1.9.1-rc1> and > > > Apache.Avro.Tools > > > v1.9.1-rc1 <https://www.nuget.org/packages/Apache.Avro.Tools/1.9.1-rc1> > to > > > nuget.org. > > > > > > On Tue, Aug 20, 2019 at 3:44 PM Driesprong, Fokko <[email protected] > > > > > wrote: > > > > > > > Thanks, Dan for giving it a try. My mistake, this file comes from the > > > > test-suite. I'll clean up the repo and publish a new package. > > > > > > > > Cheers, Fokko > > > > > > > > Op di 20 aug. 2019 om 21:41 schreef Daniel Kulp <[email protected]>: > > > > > > > > > Java doesn’t build. There is an empty file: > > > > > > > > > > > > > > > > > > > > > > > lang/java/mapred/src/test/resources/org/apache/avro/mapreduce/mapreduce-test-input.avro/SUCCESS.crc > > > > > > > > > > In the tar that doesn’t seem to be in the git repo. It’s causing a > > > > > problem with RAT since there isn’t a license header or anything. > I’m > > > > not > > > > > sure where that file came from. > > > > > > > > > > > > > > > Dan > > > > > > > > > > > > > > > > > > > > > > > > > > On Aug 20, 2019, at 2:04 PM, Driesprong, Fokko > <[email protected] > > > > > > > > > wrote: > > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > I'm delighted to propose the following RC to be released as > official > > > > > Apache > > > > > > Avro 1.9.1 release. > > > > > > > > > > > > The commit id is aad028bf84d43cc3481ac8b527f30debbdf213d2 > > > > > > * This corresponds to the tag: release-1.9.1-rc1 > > > > > > * https://github.com/apache/avro/releases/tag/release-1.9.1-rc1 > > > > > > > > > > > > The release tarball, signature, and checksums are here: > > > > > > * https://dist.apache.org/repos/dist/dev/avro/avro-1.9.1-rc1/ > > > > > > > > > > > > You can find the KEYS file here: > > > > > > * https://dist.apache.org/repos/dist/dev/avro/KEYS > > > > > > > > > > > > Binary artifacts for Java are staged in Nexus here: > > > > > > * > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/groups/staging/org/apache/avro/avro/1.9.1/ > > > > > > > > > > > > This release includes 31 Jira issues: > > > > > > > > > > > > > > > > > > > https://jira.apache.org/jira/issues/?jql=project%20%3D%20AVRO%20AND%20fixVersion%20%3D%201.9.1 > > > > > > * Most important, fix regression issues: > > > > > > * Java: decoding schema's: > > > > > https://jira.apache.org/jira/browse/AVRO-2400 > > > > > > * .Net: Performance issue: > > > > > https://jira.apache.org/jira/browse/AVRO-2396 > > > > > > * Java: Make org.apache.avro.Schema serializable > > > > > > * Java: Ability to add custom object to Velocity templating > > > > > > * Improved interoperability testing > > > > > > * Removed NPE's > > > > > > * Upgrade dependencies to latest to the latest version > > > > > > * And many more :-) > > > > > > > > > > > > Please download, verify, and test. This vote will remain open > for at > > > > > least > > > > > > 72 hours. Given sufficient votes, I would like to close it on or > > > about > > > > > > midnight > > > > > > on Saturday, 24 August 2019. > > > > > > > > > > > > [ ] +1 Release this as Apache Avro 1.9.1 > > > > > > [ ] +0 > > > > > > [ ] -1 Do not release this because... > > > > > > > > > > > > Consider this a +1 (binding) from my side: > > > > > > * Compiled against Divolte collector and Iceberg > > > > > > > > > > > > Cheers, Fokko Driesprong > > > > > > > > > > -- > > > > > Daniel Kulp > > > > > [email protected] <mailto:[email protected]> - > http://dankulp.com/blog < > > > > > http://dankulp.com/blog> > > > > > Talend Community Coder - http://talend.com < > http://coders.talend.com/> > > > > > > > > > > > > > > > > > > -- > > > > > > [image: 51b630b05e01a6d5134ccfd520f547c4.png] > > > > > > Brian Lachniet > > > > > > Software Engineer > > > > > > E: [email protected] | blachniet.com <http://www.blachniet.com> > > > > > > <https://twitter.com/blachniet> <http://www.linkedin.com/in/blachniet> > > > >
