[
https://issues.apache.org/jira/browse/AVRO-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921945#comment-16921945
]
Hudson commented on AVRO-2454:
------------------------------
SUCCESS: Integrated in Jenkins build AvroJava #735 (See
[https://builds.apache.org/job/AvroJava/735/])
AVRO-2454: Fix CA1034 - Nested types should not be visible (blachniet:
[https://github.com/apache/avro/commit/a1d9b1a64c5c5ca273e5f6dfcf6015a7d1e0cc8f])
* (edit) lang/csharp/src/apache/main/Specific/ObjectCreator.cs
* (edit) lang/csharp/Avro.ruleset
AVRO-2454: Fix SA1600 - Elements should be documented (blachniet:
[https://github.com/apache/avro/commit/21698b9baa331e0f2506acb4c1b5408c1b84f071])
* (edit) lang/csharp/Avro.ruleset
* (edit) lang/csharp/stylecop.json
* (edit) lang/csharp/src/apache/main/Specific/ObjectCreator.cs
AVRO-2454: Fix CA1052 - Static holder types should be Static or (blachniet:
[https://github.com/apache/avro/commit/770acd5a5f2de734eb7a6e51ae18ed254b2828f8])
* (edit) lang/csharp/src/apache/main/File/DataFileConstants.cs
* (edit) lang/csharp/Avro.ruleset
AVRO-2454: Fix CA1063 - Implement IDisposable correctly (blachniet:
[https://github.com/apache/avro/commit/61e56249baa8aeb63ac4ce990ac595189e7282b4])
* (edit) lang/csharp/src/apache/main/File/DataFileReader.cs
* (edit) lang/csharp/src/apache/main/File/DataFileWriter.cs
* (edit) lang/csharp/Avro.ruleset
AVRO-2454: Ignore CA1303 - Do not pass literals as localized parameters
(blachniet:
[https://github.com/apache/avro/commit/5d3ad3e179c31a444b51bc2f6556448eb5ad3408])
* (edit) lang/csharp/Avro.ruleset
AVRO-2454: Fix CA1305 - Specify IFormatProvider (blachniet:
[https://github.com/apache/avro/commit/539d746274a01011cffe6a863d7373d3a38d4c78])
* (edit) lang/csharp/Avro.ruleset
* (edit) lang/csharp/src/apache/main/CodeGen/CodeGen.cs
* (edit) lang/csharp/src/apache/main/IO/ByteBufferInputStream.cs
* (edit) lang/csharp/src/apache/main/Schema/SchemaNormalization.cs
* (edit) lang/csharp/src/apache/main/File/DataFileReader.cs
* (edit) lang/csharp/src/apache/main/Reflect/ReflectDefaultReader.cs
AVRO-2454: Ignore SA1116 and SA1117 - Parameters on separate lines (blachniet:
[https://github.com/apache/avro/commit/33418a3955cac1c00b6c2ee31b3fc4929a54d996])
* (edit) lang/csharp/Avro.ruleset
AVRO-2454: Fix SA1119 - StatementMustNotUseUnnecessaryParenthesis (blachniet:
[https://github.com/apache/avro/commit/ded1087822b590ac5106cf58bef51c8476653743])
* (edit) lang/csharp/src/apache/main/File/NullCodec.cs
* (edit) lang/csharp/src/apache/main/Schema/RecordSchema.cs
* (edit) lang/csharp/src/apache/main/Generic/GenericDatumReader.cs
* (edit) lang/csharp/src/apache/main/Generic/PreresolvingDatumWriter.cs
* (edit) lang/csharp/src/apache/main/File/DeflateCodec.cs
* (edit) lang/csharp/src/apache/main/Schema/Field.cs
* (edit) lang/csharp/src/apache/main/Generic/GenericWriter.cs
* (edit) lang/csharp/src/apache/main/Specific/SpecificDatumWriter.cs
* (edit) lang/csharp/src/apache/main/IO/BinaryEncoder.cs
* (edit) lang/csharp/src/apache/main/Specific/SpecificWriter.cs
* (edit) lang/csharp/src/apache/main/Protocol/Protocol.cs
* (edit) lang/csharp/Avro.ruleset
* (edit) lang/csharp/src/apache/main/File/DataFileReader.cs
* (edit) lang/csharp/src/apache/main/Generic/GenericDatumWriter.cs
* (edit) lang/csharp/src/apache/main/Schema/Schema.cs
* (edit) lang/csharp/src/apache/main/Specific/SpecificDatumReader.cs
AVRO-2454: Fix CA1307 - Specify StringComparison (blachniet:
[https://github.com/apache/avro/commit/e6479eae59aa9d83d6effc7284e5a3821c5e8c14])
* (edit) lang/csharp/src/apache/main/Schema/EnumSchema.cs
* (edit) lang/csharp/src/apache/main/Protocol/Protocol.cs
* (edit) lang/csharp/src/apache/main/Generic/GenericEnum.cs
* (edit) lang/csharp/src/apache/main/Schema/Property.cs
* (edit) lang/csharp/src/apache/main/Schema/Schema.cs
* (edit) lang/csharp/src/apache/main/Schema/PrimitiveSchema.cs
* (edit) lang/csharp/src/apache/main/Protocol/Message.cs
* (edit) lang/csharp/Avro.ruleset
* (edit) lang/csharp/src/apache/main/File/DataFileWriter.cs
AVRO-2454: Fix CA1507 - Use nameof in place of string (blachniet:
[https://github.com/apache/avro/commit/0e1073e98b4323fd85af1826a72ca12d5eabc1d2])
* (edit) lang/csharp/src/apache/main/Schema/RecordSchema.cs
* (edit) lang/csharp/src/apache/main/Schema/ArraySchema.cs
* (edit) lang/csharp/Avro.ruleset
* (edit) lang/csharp/src/apache/main/Schema/FixedSchema.cs
* (edit) lang/csharp/src/apache/main/Schema/MapSchema.cs
* (edit) lang/csharp/src/apache/main/Schema/Field.cs
* (edit) lang/csharp/src/apache/main/Schema/JsonHelper.cs
* (edit) lang/csharp/src/apache/main/Schema/Schema.cs
* (edit) lang/csharp/src/apache/main/Schema/UnionSchema.cs
* (edit) lang/csharp/src/apache/main/Protocol/Protocol.cs
* (edit) lang/csharp/src/apache/main/CodeGen/CodeGen.cs
* (edit) lang/csharp/src/apache/main/Protocol/Message.cs
AVRO-2454: Fix SA1604 - ElementDocumentationMustHaveSummary (blachniet:
[https://github.com/apache/avro/commit/5b7fcf6d9a628e768410a369fd7773b46378052c])
* (edit) lang/csharp/Avro.ruleset
* (edit) lang/csharp/src/apache/main/Generic/GenericDatumReader.cs
AVRO-2454: Fix SA1606 - ElementDocumentationMustHaveSummaryText (blachniet:
[https://github.com/apache/avro/commit/2e93877491ef385455183cf9a430b54227945858])
* (edit) lang/csharp/Avro.ruleset
* (edit) lang/csharp/src/apache/main/Reflect/FuncFieldConverter.cs
AVRO-2454: Fix SA1610 - PropertyDocumentationMustHaveValueText (blachniet:
[https://github.com/apache/avro/commit/eef00d72cc172896980e515bee1a84fa3a29aa3a])
* (edit) lang/csharp/src/apache/main/Reflect/AvroFieldAttribute.cs
* (edit) lang/csharp/src/apache/main/Reflect/ArrayHelper.cs
* (edit) lang/csharp/Avro.ruleset
* (edit) lang/csharp/src/apache/main/Reflect/ReflectDefaultReader.cs
* (edit) lang/csharp/src/apache/main/Reflect/ReflectDefaultWriter.cs
* (edit) lang/csharp/src/apache/main/Reflect/ReflectWriter.cs
* (edit) lang/csharp/src/apache/main/Reflect/ReflectReader.cs
AVRO-2454: Fix SA1611 - ElementParametersMustBeDocumented (blachniet:
[https://github.com/apache/avro/commit/2641b45e2d61d718fd3301cf380ea829f2c0ae6a])
* (edit) lang/csharp/src/apache/main/Reflect/ArrayHelper.cs
* (edit) lang/csharp/src/apache/main/Generic/PreresolvingDatumReader.cs
* (edit) lang/csharp/Avro.ruleset
AVRO-2454: Fix CA1715 - Identifiers should have correct prefix (blachniet:
[https://github.com/apache/avro/commit/2014d7d6f86ad0a48f801ef152dbc88ef208f620])
* (edit) lang/csharp/src/apache/main/IO/Encoder.cs
* (edit) lang/csharp/src/apache/main/Generic/DatumReader.cs
* (edit) lang/csharp/src/apache/main/Generic/PreresolvingDatumWriter.cs
* (edit) lang/csharp/src/apache/main/Reflect/ClassCache.cs
* (edit) lang/csharp/src/apache/main/Generic/GenericReader.cs
* (edit) lang/csharp/src/apache/main/Generic/GenericWriter.cs
* (edit) lang/csharp/src/apache/main/Generic/DatumWriter.cs
* (edit) lang/csharp/Avro.ruleset
* (edit) lang/csharp/src/apache/main/IO/Decoder.cs
* (edit) lang/csharp/src/apache/main/Reflect/TypedFieldConverter.cs
* (edit) lang/csharp/src/apache/main/Reflect/FuncFieldConverter.cs
AVRO-2454: Fix CA1724 - Type names should not match namespaces (blachniet:
[https://github.com/apache/avro/commit/85016374897e776c54d7e8cfe022f60b1d4e9550])
* (edit) lang/csharp/src/apache/main/GlobalSuppressions.cs
* (edit) lang/csharp/Avro.ruleset
AVRO-2454: Fix CA1721 - Property names should not match get methods (blachniet:
[https://github.com/apache/avro/commit/2dd342921cc7264a54cd66c00528381a167230f9])
* (edit) lang/csharp/src/apache/main/GlobalSuppressions.cs
* (edit) lang/csharp/Avro.ruleset
> C#: Enforce Consistent Style
> ----------------------------
>
> Key: AVRO-2454
> URL: https://issues.apache.org/jira/browse/AVRO-2454
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Reporter: Brian Lachniet
> Assignee: Brian Lachniet
> Priority: Minor
>
> There has been an effort to normalize style and formatting in some of the
> other language implementations in the Avro project recently (AVRO-2353 for
> Java and AVRO-2410 for Python). The C# project could certainly benefit from
> normalized style as well.
> We could do this by introducing .NET Analyzers implemented in
> [FxCopAnalyzers|https://www.nuget.org/packages/Microsoft.CodeAnalysis.FxCopAnalyzers/]
> and [StyleCop.Analyzers|https://www.nuget.org/packages/StyleCop.Analyzers/].
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
