Michael A. Smith created AVRO-2593:
--------------------------------------
Summary: test_tether_word_counts errors obscured
Key: AVRO-2593
URL: https://issues.apache.org/jira/browse/AVRO-2593
Project: Apache Avro
Issue Type: Bug
Components: python
Affects Versions: 1.9.1
Reporter: Michael A. Smith
lang/py/test/test_tether_word_count.py is somewhat fragile. When it fails, the
true failure is obscured by [a secondary
error|https://github.com/apache/avro/blob/master/lang/py/test/test_tether_word_count.py#L210]
because {{exfile}} is first defined on [line
179|https://github.com/apache/avro/blob/master/lang/py/test/test_tether_word_count.py#L179]
and may not even exist in the {{finally}} block.
I propose a significant refactor of this test to make the results clearer and
to adhere to more idiomatic testing and python by:
# Isolating the main test from its setup and teardown using standard setUp and
tearDown.
# Isolating the subprocess try/finally from the entire test setup/teardown.
# Avoid having to manage multiple temporary files by running the entire test in
a temporary directory.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
