[
https://issues.apache.org/jira/browse/AVRO-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16998334#comment-16998334
]
Ryan Skraba commented on AVRO-2657:
-----------------------------------
Oh, nice catch! I didn't notice these files moved.
Perhaps a quick check to explicitly fail (for a case like this) would be to
validate the contents of the build/interop/data directory between
*interop-data-generate* and *interop-data-test* in the root `./build.sh`
script. Either count the files or verify a minimum set to make sure that all
languages participated in the setup correctly.
A heavyweight check would be to note every time we test language1 -> language2
(in a file?), and check that there aren't any "holes" in the coverage after
running all the interop tests, but that doesn't seem to offer much more for the
extra effort.
> Fix broken data interop test for Python2
> ----------------------------------------
>
> Key: AVRO-2657
> URL: https://issues.apache.org/jira/browse/AVRO-2657
> Project: Apache Avro
> Issue Type: Bug
> Components: interop, python
> Reporter: Kengo Seki
> Assignee: Michael A. Smith
> Priority: Major
>
> [~kojiromike] [~ryanskraba], after AVRO-831 has been merged, the data interop
> test for Python2 seems to be broken.
> The interop tests should refer to build/interop/data in the Avro's toplevel
> directory, but the one for Python2 refers to lang/py/avro/test/interop/data.
> So other bindings don't check the output from Python2 and vice versa for now.
> {code}
> $ ./build.sh docker
> (snip)
> sekikn@8359bbe828fe:~/avro$ ./build.sh clean test
> (snip)
> sekikn@8359bbe828fe:~/avro$ ls build/interop/data
> c.avro java.avro java_snappy.avro perl.avro
> php.avro py3_bzip2.avro py3_xz.avro ruby_deflate.avro
> csharp.avro java_bzip2.avro java_xz.avro
> perl_deflate.avro php_deflate.avro py3_deflate.avro py3_zstandard.avro
> ruby_snappy.avro
> csharp_deflate.avro java_deflate.avro java_zstandard.avro
> perl_zstandard.avro py3.avro py3_snappy.avro ruby.avro
> ruby_zstandard.avro
> sekikn@8359bbe828fe:~/avro$ ls lang/py/avro/test/interop/data
> py.avro py_deflate.avro py_snappy.avro py_zstandard.avro
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
