I may have bitten off more than I can chew here. I've been unable to cherry pick all the changes from master into 1.9. The python changes themselves are not the problem-- I think the problem is that there have been several changes to Dockerfile and the build system, some related to python and some not. Those changes are wide-ranging and not easy to cherry pick. They don't affect functionality directly, but if I skip them I don't think the tests can pass.
Does anyone with a better understanding of the 1.9 chronology want to give it a shot? On Mon, Jan 13, 2020 at 06:57 Michael A. Smith <[email protected]> wrote: > The only direct API changes were to deprecate capital-P parse in lang/py3. > The syntax is still supported, but will cause a warning. > > There are some implied API changes insofar as we dropped support for > python<2.7 as well, removing some polyfills and syntax that supported old > pythons as well. > > Unless I missed something I think we're still sufficiently API compatible. > > Cheers, Michael > > On Mon, Jan 13, 2020 at 05:01 Driesprong, Fokko <[email protected]> > wrote: > >> Hi Mike, >> >> Do you know if this introduces any breaking changes to the API? Since this >> is a minor update, we should keep the API compatible. >> >> Cheers, Fokko >> >> Op za 11 jan. 2020 om 13:51 schreef Michael A. Smith < >> [email protected]>: >> >> > So far none of my python2/3 changes have been targeting 1.9. They're >> > currently just in master. It would be great if someone could cherry pick >> > them. I'm away this weekend, but happy to help via phone or more >> directly >> > next week if it turns complex. >> > >> > Best regards, >> > Mike >> > >> > On Sat, Jan 11, 2020 at 07:39 Driesprong, Fokko <[email protected]> >> > wrote: >> > >> > > Thanks for the review Ryan, appreciate it. >> > > >> > > I'm happy to help you with the release, if you could pick that up, >> that >> > > would be great. Before starting the release process, I'd like to >> check if >> > > there are commits that are targeted for 1.10 but can be cherry-picked >> > back >> > > to 1.9.2. >> > > >> > > For doing the release, there are two important things: >> > > - Having the gpg keys in place: >> > > https://www.apache.org/dev/release-signing.html >> > > - Run the build chain for building the artifacts for the different >> > > platforms: >> > https://cwiki.apache.org/confluence/display/AVRO/How+To+Release >> > > >> > > Luckily we have Docker for the latter :-) >> > > >> > > Cheers, Fokko >> > > >> > > Op vr 10 jan. 2020 om 17:41 schreef Ryan Skraba <[email protected]>: >> > > >> > > > Hello! I read and reviewed the PR -- it looks OK to me, is there >> > > > something more to do to the current fix? >> > > > >> > > > I'd be happy to do or help out with the release ... I suspect I >> might >> > > > need a bit of hand-holding for this first time, but the doc looks >> > > > pretty complete. Alternatively, if it's easier, I could shadow >> > > > whoever is doing this one and be ready for the next. It's pretty >> > > > exciting to see the cadence pick up for Avro! >> > > > >> > > > All my best, Ryan >> > > > >> > > > On Thu, Jan 9, 2020 at 9:48 AM Driesprong, Fokko >> <[email protected] >> > > >> > > > wrote: >> > > > > >> > > > > Hi all, >> > > > > >> > > > > I'm working on bumping Apache Avro on the Apache Iceberg project: >> > > > > https://github.com/apache/incubator-iceberg/pull/297, I've >> > discovered >> > > a >> > > > > regression bug. I've managed to create a unit test that catches >> the >> > > > issue: >> > > > > https://github.com/apache/avro/pull/752. The current fix isn't >> the >> > > > correct >> > > > > one. I hope to fix it somewhere this weekend, and afterward, start >> > the >> > > > > release process for 1.9.2. >> > > > > >> > > > > If there is anything that you need to have cherry-picked onto the >> 1.9 >> > > > > branch, please let me know. Also, if there is anyone who likes to >> > > > shepherd >> > > > > the release, or wants to help out, please feel free to let me know >> > :-) >> > > > > >> > > > > Thanks all, >> > > > > >> > > > > Cheers, Fokko >> > > > >> > > >> > >> >
