Thanks Ryan for taking care of this. Unfortunately, I have to give a -1 (binding) to the RC. It turns out that AVRO-2663 wasn't properly cherry-picked. I've tried to run Avro against Iceberg, and the tests failed. It turned out that only the first commit of the PR was being cherry-picked onto the 1.9 branch. I've tested it, and after the patch, the tests in Iceberg pass as well.
I've created a PR for patching this: https://github.com/apache/avro/pull/801 Cheers, Fokko Op do 6 feb. 2020 om 14:58 schreef Ryan Skraba <r...@skraba.com>: > Hello! Two points about the release announcement! > > 1. I originally signed the artifacts in > https://dist.apache.org/repos/dist/dev/avro/avro-1.9.2-rc1/ with the wrong > key. > > I've just updated all of the *.asc files with my code signing key, so they > should be correct now (SVN revision 37897). My apologies. The nexus > artifacts were already signed with the correct key fortunately. > > 2. I missed a version change from my copy/paste in the vote text; if you > copy it from the announcement, make sure you vote for/against releasing > 1.9.2! > > All my best, Ryan > > > On Wed, Feb 5, 2020 at 5:59 PM Ryan Skraba <r...@skraba.com> wrote: > > > Hi everyone, > > > > I'd like to propose the following RC1 to be released as the official > Apache > > Avro 1.9.2 release. > > > > The commit id is 39dd5c6bb33ab6634b4ed69f591a0676be62563a > > * This corresponds to the tag: release-1.9.2-rc1 > > * https://github.com/apache/avro/releases/tag/release-1.9.2-rc1 > > > > The release tarball, signature, and checksums are here: > > * https://dist.apache.org/repos/dist/dev/avro/avro-1.9.2-rc1/ > > > > You can find the KEYS file here: > > * https://dist.apache.org/repos/dist/dev/avro/KEYS > > > > Binary artifacts for Java are staged in Nexus here: > > * > > > https://repository.apache.org/content/groups/staging/org/apache/avro/avro/1.9.2/ > > > > This release includes 57 Jira issues: > > > > > https://jira.apache.org/jira/issues/?jql=project%20%3D%20AVRO%20AND%20fixVersion%20%3D%201.9.2 > > > > * Some bug fixes: > > - C#: AVRO-2606 handle multidimensional arrays of custom types > > - Java: AVRO-2592 Avro decimal fails on some conditions > > - Java: AVRO-2641 Generated code results in > java.lang.ClassCastException > > - Java: AVRO-2663 Projection on nested records does not work > > - Python: AVRO-2429 unknown logical types should fall back > > * Improvements: > > - Java: AVRO-2247 Improve Java reading performance with a new reader > > - Python: AVRO-2104 Schema normalisation and fingerprint support for > > Python 3 > > * Work to unify Python2 and Python3 APIs in preparation for sunset. > > * Improved tests > > * Improved, more reliable builds. > > * Improved readability > > * Upgrade dependencies to latest versions, including CVE fixes. > > * And more... > > > > Please download, verify, and test. This vote will remain open for at > least > > 72 hours. Given sufficient votes, I would like to close after noon UTC > > Monday, February > > 10th > > > > [ ] +1 Release this as Apache Avro 1.9.1 > > [ ] +0 > > [ ] -1 Do not release this because... > > > > Cheers, Ryan Skraba > > >
