anhldbk commented on a change in pull request #874:
URL: https://github.com/apache/avro/pull/874#discussion_r422578604
##########
File path: lang/java/avro/src/main/java/org/apache/avro/reflect/ReflectData.java
##########
@@ -737,6 +737,9 @@ protected Schema createSchema(Type type, Map<String,
Schema> names) {
AvroName annotatedName = field.getAnnotation(AvroName.class); //
Rename fields
String fieldName = (annotatedName != null) ?
annotatedName.value() : field.getName();
+ if ("this$0".equals(fieldName)) {
Review comment:
@Fokko any clear reason? It seems to me that there's no problem with
performance:
https://stackoverflow.com/questions/53835748/java-performance-private-static-final-string-vs-local-string-number-of-objec/53837197
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
