Fokko commented on a change in pull request #876:
URL: https://github.com/apache/avro/pull/876#discussion_r422677098
##########
File path: lang/php/lib/avro/data_file.php
##########
@@ -209,12 +209,12 @@ class AvroDataIOReader
/**
* @var string
*/
- private $sync_marker;
+ public $sync_marker;
Review comment:
I think we still want to keep this private, as we don't want to expose
this outside the object. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
