tom-j-irvine opened a new pull request #1070:
URL: https://github.com/apache/avro/pull/1070


   This PR preserves the schema "doc" attributes when serializing the schema to 
json.  The existing code would parse and include the documentation, but it 
wasn't passed along when serializing the schema.
   
   ### Jira
   
   Jira Issue AVRO-2633  - C# - AvroGen tool - Document for record type is not 
included in the Schema field.  
   
   https://issues.apache.org/jira/projects/AVRO/issues/AVRO-2633
   
   This pull request makes preserves the schema documentation when serializing 
the schema.
   
   ### Tests
   
   My PR adds a new test case to SchemaTests.TestBasic
   My PR adjusts SchemaTests.testFullName to use a modified constructor
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines. In 
addition, my commits follow the guidelines from "[How to write a good git 
commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   C# XML comments were updated for all modified methods


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to