[ 
https://issues.apache.org/jira/browse/AVRO-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277357#comment-17277357
 ] 

Andrew Olson commented on AVRO-2944:
------------------------------------

[~rskraba] I've opened https://github.com/apache/avro/pull/1080 to 
refactor/improve that loop. Let me know what you think.

> DataFileReader has incorrect logic reading magic header
> -------------------------------------------------------
>
>                 Key: AVRO-2944
>                 URL: https://issues.apache.org/jira/browse/AVRO-2944
>             Project: Apache Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.9.2
>            Reporter: Mick Jermsurawong
>            Assignee: Mick Jermsurawong
>            Priority: Major
>             Fix For: 1.10.1
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When creating reader using static method which includes checking for magic 
> header, we currently read 4 bytes but the pointer is not correctly updated.
> [https://github.com/apache/avro/blob/328c539afc77da347ec52be1e112a6a7c371143b/lang/java/avro/src/main/java/org/apache/avro/file/DataFileReader.java#L61-L62]
> When inputstream reads less byte than expected, this will get stuck in the 
> loop until the end of file. Or if inputstream returns -1, for EOF like 
> S3AInpustream, read hangs in this loop.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to