[ 
https://issues.apache.org/jira/browse/AVRO-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296885#comment-17296885
 ] 

ASF subversion and git services commented on AVRO-2933:
-------------------------------------------------------

Commit 04928ad70d7c56f821f0cce2033984874c13f53a in avro's branch 
refs/heads/master from Thomas-Barbier-1A
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=04928ad ]

Tentative fix for AVRO-2933 avro c++ CMakeList enforces a specific version of 
C++ instead of letting user CXXFLAGS (#960)



> avro c++ CMakeList enforces a specific version of C++ instead of letting user 
> CXXFLAGS
> --------------------------------------------------------------------------------------
>
>                 Key: AVRO-2933
>                 URL: https://issues.apache.org/jira/browse/AVRO-2933
>             Project: Apache Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.10.0, 1.9.2
>            Reporter: Thomas Barbier
>            Priority: Minor
>
> Hello,
> I have an issue with Avro C++: 
> The CMakeList enforces the use of C++11 
> (https://github.com/apache/avro/blob/master/lang/c%2B%2B/CMakeLists.txt#L57)
> {code:java}
> add_definitions(-std=c++11 -fPIC)
> {code}
> In local, I need to build with c++20 and therefore removed this line from my 
> CMakeList (the std== parameters is in my CXXFLAGS).
>  
> As I don't know what is the best practice to let users choose their C++ 
> version I create the issue to open the discussion and will submit a PR in 
> case you agree with it.
>  
> Best Regards
> Thomas
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to