subhashb opened a new pull request #1167:
URL: https://github.com/apache/avro/pull/1167


   This PR adds support for generating Parsing Canonical Forms of Avro Schemas 
to the main `avro` package.
   
   The bulk of the work was done by @kojiromike and @forsberg. This PR cleans 
up code where necessary, adds more test cases, and clarifies on transformations 
wherever not applicable in Python (ex. Transformation of integers with leading 
zeros)
   
   Closes: https://issues.apache.org/jira/browse/AVRO-1938
   Original PR: https://github.com/apache/avro/pull/700/
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Avro 
Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them 
in the PR title.
     - https://issues.apache.org/jira/browse/AVRO-1938
   
   ### Tests
   
   - [x] My PR adds the following unit tests:
     Test cases in `test/test_schema.py::CanonicalFormTestCase`
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines. In 
addition, my commits follow the guidelines from "[How to write a good git 
commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes 
how to use it.
     Test cases act as stand-ins for the feature for now. Comprehensive 
documentation needs to be added later.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to