[
https://issues.apache.org/jira/browse/AVRO-3173?focusedWorklogId=646295&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646295
]
ASF GitHub Bot logged work on AVRO-3173:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Sep/21 13:12
Start Date: 03/Sep/21 13:12
Worklog Time Spent: 10m
Work Description: RyanSkraba closed pull request #1283:
URL: https://github.com/apache/avro/pull/1283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 646295)
Time Spent: 20m (was: 10m)
> Rust: fix panic messages in test code
> -------------------------------------
>
> Key: AVRO-3173
> URL: https://issues.apache.org/jira/browse/AVRO-3173
> Project: Apache Avro
> Issue Type: Improvement
> Components: rust
> Reporter: Martin Tzvetanov Grigorov
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Running `cargo test` (Rust 1.53.0) produces the following warnings:
>
> {code:java}
> warning: panic message is not a string literal
> --> tests/schema.rs:1173:13
> |
> 1173 | e.to_string()
> | ^^^^^^^^^^^^^
> |
> = note: `#[warn(non_fmt_panic)]` on by default
> = note: this is no longer accepted in Rust 2021
> help: add a "{}" format string to Display the message
> |
> 1173 | "{}", e.to_string()
> | ^^^^^warning: 1 warning emitted
> {code}
>
> {code:java}
> warning: panic message is not a string literal
> --> tests/io.rs:105:13
> |
> 105 | format!("value {:?} does not validate schema: {}", value,
> raw_schema)
> |
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> |
> = note: `#[warn(non_fmt_panic)]` on by default
> = note: this is no longer accepted in Rust 2021
> = note: the panic!() macro supports formatting, so there's no need for
> the format!() macro here
> help: remove the `format!(..)` macro call
> |
> 105 | "value {:?} does not validate schema: {}", value, raw_schema
> | --
> --warning: 1 warning emitted{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
