wx930910 opened a new pull request #1341: URL: https://github.com/apache/avro/pull/1341
### Jira - AVRO-3211: Refactor PrintingVisitor to improve test design ### Description #### Replace test class [PrintingVisitor](https://github.com/apache/avro/blob/42822886c28ea74a744abb7e7a80a942c540faa5/lang/java/compiler/src/test/java/org/apache/avro/compiler/schema/TestSchemas.java#L41) by mocking object and improve test design <hr> ##### Motivation - Decouple test class `PrintingVisitor` from production interface `SchemaVisitor`. - Remove the redundant test child class `PrintingVisitor`. <hr> ##### Key changed/added classes in this PR * Created mocking object to replace test subclass `PrintingVisitor`, decoupled test from production code. * Created method that return the mocking object for code reuse. * Make test logic more clear by using method stub instead of method overriding. * Remove redundant overridden method `get()`. * Add Mockito dependency. <hr> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
