[
https://issues.apache.org/jira/browse/AVRO-3212?focusedWorklogId=653053&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-653053
]
ASF GitHub Bot logged work on AVRO-3212:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Sep/21 15:37
Start Date: 20/Sep/21 15:37
Worklog Time Spent: 10m
Work Description: radai-rosenblatt commented on a change in pull request
#1342:
URL: https://github.com/apache/avro/pull/1342#discussion_r712285901
##########
File path: doc/src/content/xdocs/spec.xml
##########
@@ -254,14 +254,16 @@
<section>
<title>Fixed</title>
<p>Fixed uses the type name <code>"fixed"</code> and supports
- two attributes:</p>
+ the following attributes:</p>
<ul>
<li><code>name</code>: a string naming this fixed (required).</li>
<li><em>namespace</em>, a string that qualifies the name;</li>
Review comment:
changed <em> to <code> for namespace - at least I cant think
of a reason why it's different?
i agree namespace should be marked optional (it is. it is also ignored is
name has dots in it), but will leave that to a committer to decide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 653053)
Time Spent: 50m (was: 40m)
> Avro Specification does not allow type fixed to have a doc property
> -------------------------------------------------------------------
>
> Key: AVRO-3212
> URL: https://issues.apache.org/jira/browse/AVRO-3212
> Project: Apache Avro
> Issue Type: Bug
> Components: doc
> Affects Versions: 1.10.2
> Reporter: radai rosenblatt
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> according to the [latest
> spec|http://avro.apache.org/docs/current/spec.html#Fixed]:
> {quote}
> Fixed uses the type name "fixed" and supports two attributes:
> name
> namespace
> aliases
> size
> {quote}
>
> those are 4 attributes, and also "doc" isnt mentioned (though very much
> supported at least in java code)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
