[
https://issues.apache.org/jira/browse/AVRO-3197?focusedWorklogId=653979&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-653979
]
ASF GitHub Bot logged work on AVRO-3197:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Sep/21 09:10
Start Date: 22/Sep/21 09:10
Worklog Time Spent: 10m
Work Description: gudjonragnar commented on a change in pull request
#1340:
URL: https://github.com/apache/avro/pull/1340#discussion_r713747331
##########
File path: lang/rust/tests/schema.rs
##########
@@ -19,6 +19,13 @@
use avro_rs::{schema::Name, Error, Schema};
use lazy_static::lazy_static;
+fn init() {
Review comment:
ye I agree, or even something like pytests fixtures.
I see your point with possibly adding more to the init, however I often
favour separating the `inits` unless they are necessary inits for all of the
tests. In this case it is more of a nitpick comment, so I don't mind you
disregarding it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 653979)
Time Spent: 50m (was: 40m)
> Rust: Disable logical type on failure
> -------------------------------------
>
> Key: AVRO-3197
> URL: https://issues.apache.org/jira/browse/AVRO-3197
> Project: Apache Avro
> Issue Type: Wish
> Reporter: Guðjón
> Assignee: Martin Tzvetanov Grigorov
> Priority: Minor
> Labels: pull-request-available
> Attachments: weather.avro, weather2.avro
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> I have a file containing avro records along with a schema. The schema
> contains a field that unfortunately has the type `String` but logical type
> `timestamp-millis`. The Java implementation of the avro spec doesn't complain
> and simply treats this field as a string, but the rust implementation will
> return an error since the string type doesn't match with the logical type of
> timestamp (long).
> I wonder if there could be a possibility to optionally disregard the logical
> type if this failure is encountered.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
