[
https://issues.apache.org/jira/browse/AVRO-3048?focusedWorklogId=657408&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-657408
]
ASF GitHub Bot logged work on AVRO-3048:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Sep/21 16:53
Start Date: 29/Sep/21 16:53
Worklog Time Spent: 10m
Work Description: RyanSkraba commented on pull request #1333:
URL: https://github.com/apache/avro/pull/1333#issuecomment-930355417
Oh, as a quick note -- the Avro convention (for historical reasons) is that
`1.11.0` is a major release, and `1.10.3` is a minor release! It's unexpected
AND undocumented (at least you have to search for it).
All that being said, pragmatically for your immediate problem, I think
you'll find `1.10.2` -> `1.11.0` to be a pretty easy migration, so I'm going to
focus on that. Depending on the outcome of the discussion on the mailing list,
we can revisit supporting a `1.10.3` and _especially_ policy and process
improvements for the future!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 657408)
Time Spent: 1h 20m (was: 1h 10m)
> Using builders leads to performance degradation
> -----------------------------------------------
>
> Key: AVRO-3048
> URL: https://issues.apache.org/jira/browse/AVRO-3048
> Project: Apache Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.9.2, 1.10.1
> Reporter: Peter
> Assignee: Martin Jubelgas
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> When you do a .newBuilder() for avro generated classes, this will call
> org.apache.avro.specific.SpecificData.getForSchema:
>
> public static SpecificData getForSchema(Schema reader) {
> if (reader.getType() == Type.RECORD) {
> final String className = getClassName(reader);
> if (className != null) {
> final Class<?> clazz;
> try
> {
> clazz = Class.forName(className);
> return getForClass(clazz); }
> catch (ClassNotFoundException e)
> { return SpecificData.get();
> }
> }
> }
>
> which seems then to seldom find the value inside the try and a lot of
> ClassNotFoundException is thrown.
> Throwing internal exceptions has great performance penalties and in practice
> users of avro 1.9.x. and 1.10.x in high performance applications are forced
> not to use builders.
>
> Information about same problem is also found on:
> [https://forums.databricks.com/questions/50803/orgapacheavrospecificspecificdatagetforschema-sear.html]
> Problem exists on at least 1.9.2 and 1.10.1 (but not on 1.7.x) in OSGI
> environment
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
