[
https://issues.apache.org/jira/browse/AVRO-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427484#comment-17427484
]
Rasmus Helbig Hansen edited comment on AVRO-3154 at 10/12/21, 6:52 AM:
-----------------------------------------------------------------------
You're right, [~unchuckable]. I forgot that it is just me, who is always
keeping the fastread feature enabled. It seems like an easy choice, when you're
working with GenericData. It just works. That's my vote: Enable fastread by
default.
The fastread feature doesn't appear in the documentation currently, but it
would make sense to have both feature available to you, since they cover
overlapping, but not identical parts of the encode/decode-generic/specific
matrix. The custom-coders feature should probably take precedence for the
decode-specific case though. Of course all of that requires the custom-coders
feature to be finalized.
was (Author: rasmusatnordea):
You're right, [~unchuckable]. I forgot that it is just me, who is always
keeping the fast-reader feature enabled. It seems like an easy choice, when
you're working with GenericData. It just works. That's my vote.
The fast-reader feature doesn't appear in the documentation currently, but it
would make sense to have both feature available to you, since they cover
overlapping, but not identical parts of the encode/decode-generic/specific
matrix. The custom-coders feature should probably take precedence for the
decode-specific case though. Of course all of that requires the custom-coders
feature to be finalized.
> Missing customEncode method for Java class generated from schema with logical
> type timestamp-millis
> ---------------------------------------------------------------------------------------------------
>
> Key: AVRO-3154
> URL: https://issues.apache.org/jira/browse/AVRO-3154
> Project: Apache Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.10.2
> Environment: Java version:
> OpenJDK Runtime Environment AdoptOpenJDK-16.0.1+9 (build 16.0.1+9)
> OpenJDK 64-Bit Server VM AdoptOpenJDK-16.0.1+9 (build 16.0.1+9, mixed mode,
> sharing)
> MacOs default console
> Reporter: Jakub Hałun
> Priority: Major
> Attachments: TableChangeAvro.java
>
>
> I'm trying to compile avro schema to java class with the command:
> {{java -jar avro-tools-1.10.2.jar compile schema }}
> Prepared schema is as follows:
> ^{^
> ^"type": "record",^
> ^"name": "TableChangeAvro",^
> ^"fields": [^
> ^{^
> ^"name": "ownerProjectId",^
> ^"type": "string"^
> ^},^
> ^{^
> ^"name": "dataset",^
> ^"type": "string"^
> ^},^
> ^{^
> ^"name": "table",^
> ^"type": "string"^
> ^},^
> ^{^
> ^"name": "timestamp",^
> ^"type" : {^
> ^"type" : "long",^
> ^"logicalType" : "timestamp-millis"^
> ^}^
> ^}^
> ^]^
> ^}^
> The schema compiles successfully to Java class (attached), but the class has
> missing methods:
> public void customEncode(Encoder out) throws IOException
> public void customDecode(ResolvingDecoder in) throws IOException
>
> Because of that, I'm unable to use it for Google Pub/Sub publication as
> intended. The problem occurs for the schema only when the type with
> timestamp-millis logical type is included.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
