[
https://issues.apache.org/jira/browse/AVRO-2666?focusedWorklogId=665061&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-665061
]
ASF GitHub Bot logged work on AVRO-2666:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Oct/21 18:40
Start Date: 13/Oct/21 18:40
Worklog Time Spent: 10m
Work Description: tjwp opened a new pull request #1367:
URL: https://github.com/apache/avro/pull/1367
This change removes the outdated [echoe gem](https://github.com/evan/echoe)
by maintaining a gemspec file in source code and using gem tasks provided by
bundler.
The approach here mostly follows what would be generated by `bundle gem` for
a new gem today. There are a couple of key places where it differs:
- the gem version is not maintained in source code under the Ruby folder.
Instead it is copied into a text file from the `share` directory. This now
happens in the `Gemfile` to ensure that it is present for all `bundle` commands.
- the existing `Manifest` file is used to define the list of files that were
package. This was kept to ensure that compatibility was maintained with the old
packaging.
### Jira
- [x] My PR addresses the following [Avro
Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them
in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-2666
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
- This change covers the build, not a change in functionality.
### Commits
- [x] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 665061)
Time Spent: 0.5h (was: 20m)
> Replace echoe for packing the Ruby gem
> --------------------------------------
>
> Key: AVRO-2666
> URL: https://issues.apache.org/jira/browse/AVRO-2666
> Project: Apache Avro
> Issue Type: Bug
> Components: ruby
> Affects Versions: 1.9.1
> Reporter: Fokko Driesprong
> Assignee: Tim Perkins
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Echoe is a packaging tool that is no longer maintained and was last updated
> over 5 years ago. We should look into updating how the Avro ruby gem is
> packaged.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
