Adam-McDevitt opened a new pull request #1381: URL: https://github.com/apache/avro/pull/1381
Hello! This inconsistency between the schema compatibility checks and the resolver has tripped me up a few times, so I'd like to put in a fix for it. I didn't get any comments on my original issue and never got around to bumping it, so hopefully I've not misinterpreted this as a bug - it does seem to me to be an inconsistency with the specification. --- Make sure you have checked _all_ steps below. ### Jira - [X] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issue and references them in the PR title. For example, "AVRO-1234: My Avro PR" - https://issues.apache.org/jira/browse/AVRO-3133 - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). ### Tests - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: - unit test to demonstrate that schema compatibility checks are consistent with the spec in that they use unqualified namespaces for an ENUM - unit test to demonstrate that resolver has been fixed to be consistent with the spec, and now uses unqualified namespaces for resolving an ENUM or FIXED ### Commits - [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [X] In case of new functionality, my PR adds documentation that describes how to use it. - All the public functions and the classes in the PR contain Javadoc that explain what it does -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
