[
https://issues.apache.org/jira/browse/AVRO-3257?focusedWorklogId=685370&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685370
]
ASF GitHub Bot logged work on AVRO-3257:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Nov/21 15:57
Start Date: 23/Nov/21 15:57
Worklog Time Spent: 10m
Work Description: opwvhk commented on a change in pull request #1411:
URL: https://github.com/apache/avro/pull/1411#discussion_r755272274
##########
File path:
lang/java/compiler/src/main/javacc/org/apache/avro/compiler/idl/idl.jj
##########
@@ -1444,15 +1443,42 @@ Schema UnannotatedType(Map<String, JsonNode> props):
{
Schema s;
}
+{
+ (
+ s = NullableType(props)
Review comment:
This is what makes the magic possible:
1. Primitive/logical & reference types are handled differently (elsewhere)
2. The other types are handled as usual
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 685370)
Time Spent: 0.5h (was: 20m)
> IDL: add syntax to create optional fields
> -----------------------------------------
>
> Key: AVRO-3257
> URL: https://issues.apache.org/jira/browse/AVRO-3257
> Project: Apache Avro
> Issue Type: Improvement
> Components: java, spec
> Reporter: Oscar Westra van Holthe - Kind
> Assignee: Oscar Westra van Holthe - Kind
> Priority: Minor
> Labels: javacc, pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> To define optional values, Avro has the "union with the null type"
> construction.
> In IDL, this is a rather verbose construct:
> {code}
> union {null, string} optionalName = null;
> {code}
> Wish: add Kotlin style optional types like this:
> {code}
> string? optionalName = null;
> {code}
> The resulting schema should be identical; it's only a syntax change.
> Note: it would be nice (but not required) if the syntax would also work if
> the default value is not null:
> {code}
> string? optionalName = "Jane Doe";
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
